Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for older os version sketchbook location #61

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

mingness
Copy link
Collaborator

@mingness mingness commented Nov 28, 2024

Both the mac and windows default folder paths for the sketchbook were apparently taken from an outdated source. Both OSes now store the sketchbook in "$userHome/Documents/Processing" in the latest version of Processing. However, the Processing source code still seems to expect a sketchbook folder, so both of these options are checked in the gradle build file.

Copy link

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-01 13:09 UTC

@mingness mingness requested a review from SableRaf November 28, 2024 22:58
@Stefterv
Copy link
Collaborator

The best approach would be to look at the sketchbook.path.four in the prefrences.txt the sketchbook location can be dynamic based on that

@mingness
Copy link
Collaborator Author

The best approach would be to look at the sketchbook.path.four in the prefrences.txt the sketchbook location can be dynamic based on that

Thanks @Stefterv - where is this file?

@Stefterv
Copy link
Collaborator

Take a look at the getSettingsFolder() functions in the different platforms: https://github.com/processing/processing4/tree/main/app/src/processing/app/platform

@mingness
Copy link
Collaborator Author

Thanks - I just wanted to verify that it was referring to something in the Processing environment. Currently, the template is not Processing aware, it just makes assumptions where things might be. Making the template Processing aware might be a smart thing to do, but I suggest it is a bigger task than this PR, which is a momentary bug fix on sketchbook locations. I'll add your suggestions to the issues.

@Stefterv
Copy link
Collaborator

Fair

@mingness mingness merged commit c86906c into main Dec 1, 2024
1 check passed
@mingness mingness deleted the sketchbook-by-os branch December 1, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants