Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated files from updated build script (processing-doclet) #516

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

SableRaf
Copy link
Collaborator

These files were created by running the processingrefBuild.sh script as updated by Kevin in processing/processing-doclet#5

These files were created by running the `processingrefBuild.sh` script as updated by Kevin in processing/processing-doclet#5
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for java-processing-faf822 ready!

Name Link
🔨 Latest commit d281ec1
🔍 Latest deploy log https://app.netlify.com/sites/java-processing-faf822/deploys/65faba1bcbe3e10008c89f10
😎 Deploy Preview https://deploy-preview-516--java-processing-faf822.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SableRaf
Copy link
Collaborator Author

@kevinstadler check out the sound doc on the deploy preview. Is everything as it should be?

@kevinstadler
Copy link
Contributor

Yes, that is all looking good! The method signatures will look even more clear when processing/processing-doclet#6 is also merged, but since this will also affect the documentation of other libraries maybe we should have a closer look at this at OSSACC before merging...

@SableRaf
Copy link
Collaborator Author

Thanks for the feedback @kevinstadler!

I made a branch on the processing-doclet repo to merge both your PRs and ran ./processingrefBuild.sh sound on it so that it won't affect other libs.

Please check the updated deploy test and let me know how it looks.

@kevinstadler
Copy link
Contributor

Yes looks good! I just published the new release to both the latest and the v2.4.0 tag, so I guess it will be automatically drawn to the contribution manager tomorrow?

@SableRaf SableRaf merged commit 0dae021 into main Mar 26, 2024
4 checks passed
@SableRaf
Copy link
Collaborator Author

@kevinstadler Yes, Processing Sound 2.4.0 been correctly added to the contribution manager. Congratulations on the release 🎉 I have merged this PR and the updated documentation is live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants