-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudflare Pages link as PR comment #1109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulgupta2048
force-pushed
the
vipulgupta2048/link-cf-pr
branch
from
July 10, 2024 19:30
610f07f
to
6314b50
Compare
auto-merge was automatically disabled
July 10, 2024 19:30
Pull request was converted to draft
vipulgupta2048
force-pushed
the
vipulgupta2048/link-cf-pr
branch
from
July 12, 2024 23:10
294697c
to
04b0f5c
Compare
vipulgupta2048
force-pushed
the
vipulgupta2048/link-cf-pr
branch
2 times, most recently
from
July 12, 2024 23:10
3bf79ee
to
c30fc25
Compare
ab77
approved these changes
Jul 13, 2024
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
klutchell
force-pushed
the
vipulgupta2048/link-cf-pr
branch
from
July 13, 2024 14:59
c30fc25
to
cb93021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to find the CF pages link from inside the GHA run summary, lost of people have had this friction.
No more. This PR adds that link to the comments.
Zulip: Started from https://balena.zulipchat.com/#narrow/stream/408336-aspect.2Fuser-experience/topic/Where.20should.20SAML.20docs.20fit.20in.3F
Signed-off-by: Vipul Gupta (@vipulgupta2048) [email protected]