Merge pull request #13 from productboard/remove-case-sensitivity

Remove case sensitivity for collocate fragment spreads
productboard · Aug 30, 2024 · 9a86240 · 9a86240
2 parents b573618 + 99811cf
commit 9a86240
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/src/rule-must-colocate-fragment-spreads.js b/src/rule-must-colocate-fragment-spreads.js
@@ -103,10 +103,6 @@ function getGraphQLFragmentSpreads(graphQLAst) {
   return fragmentSpreads;
 }
 
-function isFirstLetterUppercase(word) {
-  return /^\p{Lu}/u.test(word);
-}
-
 function getGraphQLFragmentDefinitionName(graphQLAst) {
   let name = null;
   visit(graphQLAst, {
@@ -171,11 +167,7 @@ function checkColocation(context) {
     ImportDeclaration(node) {
       if (node.importKind === 'value') {
         node.specifiers.forEach(specifier => {
-          if (
-            allowNamedImports &&
-            specifier.imported &&
-            isFirstLetterUppercase(specifier.imported.name)
-          ) {
+          if (allowNamedImports && specifier.imported) {
             foundImportedModules.push({
               type: 'namedImport',
               value: specifier.imported.name

diff --git a/test/must-colocate-fragment-spreads.js b/test/must-colocate-fragment-spreads.js
@@ -50,6 +50,16 @@ ruleTester.run(
         `,
         options: [{allowNamedImports: true}]
       },
+      {
+        code: `
+          import { useHook } from '@some/module';
+          
+          graphql\`fragment foo on Page {
+            ...useHook
+          }\`;
+          `,
+        options: [{allowNamedImports: true}]
+      },
       `
       const Component = require('../shared/component.js');
       graphql\`fragment foo on Page {