Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ods #41

Closed
wants to merge 4 commits into from
Closed

Add ods #41

wants to merge 4 commits into from

Conversation

mixx3
Copy link
Member

@mixx3 mixx3 commented May 8, 2024

#34

Copy link

github-actions bot commented May 8, 2024

💩 Code linting failed, use black and isort to fix it.

profcomff_definitions/ODS/timetable.py Show resolved Hide resolved
profcomff_definitions/ODS/timetable.py Show resolved Hide resolved
Comment on lines +54 to +60
op.create_index(
op.f('ix_ODS_TIMETABLE_ods_timetable_act_event_text'),
'ods_timetable_act',
['event_text'],
unique=False,
schema='ODS_TIMETABLE',
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ого
А зачем это?

op.create_group(
"test_dwh_ods_timetable_all" if os.getenv("ENVIRONMENT") != "production" else "prod_dwh_dm_infra_logs_all"
)
op.grant_on_table(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Грант на схему не сгенерировался?

Comment on lines +75 to +77
op.drop_index(
op.f('ix_ODS_TIMETABLE_ods_timetable_act_event_text'), table_name='ods_timetable_act', schema='ODS_TIMETABLE'
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А он не должен быть удален первым?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants