Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): Create a db table to store preferred review tags #144

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat(db): Create a db table to store preferred review tags #144

merged 1 commit into from
Sep 12, 2024

Conversation

shivarm
Copy link
Member

@shivarm shivarm commented Sep 11, 2024

Create a db table to store preferred review tags

fixes: #139

amandesai01
amandesai01 requested changes Sep 11, 2024
View reviewed changes
server/db/schema.ts Outdated Show resolved Hide resolved
shared/schemas/review-tags.ts Outdated Show resolved Hide resolved
@amandesai01
Copy link
Member

@shivam-sharma7 claim the issue before raising PR 🙏

@shivarm shivarm force-pushed the create-review_tags-table branch from 9b23ed6 to 6c2ad0f Compare September 12, 2024 12:36
@shivarm shivarm requested a review from amandesai01 September 12, 2024 14:27
amandesai01
amandesai01 requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@amandesai01 amandesai01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add migrations. Run yarn migration:generate.

shared/schemas/review-tags.ts Outdated Show resolved Hide resolved
@shivarm shivarm force-pushed the create-review_tags-table branch from 00f1ef5 to e18a8a9 Compare September 12, 2024 14:55
@shivarm shivarm requested a review from amandesai01 September 12, 2024 14:55
@shivarm
Copy link
Member Author

shivarm commented Sep 12, 2024

Also add migrations. Run yarn migration:generate.

done

@amandesai01 amandesai01 merged commit 3cc82f4 into profilecity:main Sep 12, 2024
1 check passed
@shivarm shivarm deleted the create-review_tags-table branch September 12, 2024 14:58
HemalDesai pushed a commit to HemalDesai/vidur that referenced this pull request Sep 13, 2024
@shivarm @HemalDesai
feat(db): preferred review tags table (profilecity#144)
2bf3c1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandesai01 amandesai01 amandesai01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a db table to store preferred review tags
2 participants
@shivarm @amandesai01