feat: update createdAt and updatedAt fields to store timestamps in UTC #155
Conversation
server/db/schema.ts
Outdated
| createdAt: timestamp('created_at', { withTimezone: true }).defaultNow().notNull(), | ||
| updatedAt: timestamp('updated_at', { withTimezone: true }).defaultNow().notNull(), |
There was a problem hiding this comment.
If you need timezone, convert it to client's time zone on client-side. Keep default timezone to UTC.
There was a problem hiding this comment.
{withTimezone: true} takes care that the timestamp stored in DB is in UTC format
There was a problem hiding this comment.
understood, did some research. give me some time to merge.
Question: what will happen to existing dates? which are already in database?
As per my research, data will still be the same, it's just postgres will assume they are in UTC. However, since server is in us-east, i.e. UTC−05:00 current timestamps are stored in that format. Now how do we deal with this? Will we have to write a seed which retrieves time, converts to UTC and saves it back?
There was a problem hiding this comment.
As per debugging, current timestamps are saved in UTC, so no need for seed.
|
Final resolution: timestamps are already stored in UTC. So we won't be storing timezone, rather, we will be converting them to client timezone in client side. We will use some date library to do this. |
Feature Title[Follow conventional title. See: https://www.conventionalcommits.org/en/v1.0.0/]
Type of Change
Describe your changes
[A brief overview of the feature being added. Explain the functionality and its intended purpose.]
Screenshots/Videos (if applicable)
[Attach screenshots or videos demonstrating the new feature in action.]
Loom Video: loom
Checklist