[FIX] Grant maintainer privileges to superuser and fix attention set handling #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR grants maintainer privileges to superusers to ensure consistency with other PRs. It also fixes two bugs: the 'Review Interest' column in the patch list template was showing all users who had been added to the attention set, even if they were later removed; and the patch details view would cause an error if a user who was removed from the attention set tried to declare interest again. Additionally, it fixes problems in the partial update implementation used to change the attention set, which was not checking if a non-maintainer user was changing only the attention set field, causing the tests to break.
Progress
Pull request checklist
How to test it
Log in as a normal user and declare interest in a patch. Log in as a different user with superuser status and navigate to the patch details page. Remove the first user's interest in the patch, check it works. Repeat the process using the API. Once the user's interest has been removed, log back in as the normal user and try to declare interest in the same patch again, check it works.