Skip to content

[FIX] Grant maintainer privileges to superuser and fix attention set handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: i507
Choose a base branch
from

Conversation

DATVenancio
Copy link

@DATVenancio DATVenancio commented Jun 11, 2025

Description

This PR grants maintainer privileges to superusers to ensure consistency with other PRs. It also fixes two bugs: the 'Review Interest' column in the patch list template was showing all users who had been added to the attention set, even if they were later removed; and the patch details view would cause an error if a user who was removed from the attention set tried to declare interest again. Additionally, it fixes problems in the partial update implementation used to change the attention set, which was not checking if a non-maintainer user was changing only the attention set field, causing the tests to break.

Progress

  • Grant maintainer privileges to superusers in the API.
  • Grant maintainer privileges to superusers in the view.
  • Fix bug where excluded users were still shown in the patch list template.
  • Fix bug preventing a removed user from declaring interest again in the patch details view.
  • Fix partial update implementation to check if a non-maintainer user is changing only the attention set.

Pull request checklist

  • Tests: This PR includes tests for covering the features or bug fixes (if applicable).
  • Docs: This PR updates/creates the necessary documentation.
  • CI: Make sure your Pull Request passes all CI checks. If not, clarify the motif behind that and the action plan to solve it (may reference a ticket)

How to test it

Log in as a normal user and declare interest in a patch. Log in as a different user with superuser status and navigate to the patch details page. Remove the first user's interest in the patch, check it works. Repeat the process using the API. Once the user's interest has been removed, log back in as the normal user and try to declare interest in the same patch again, check it works.

@DATVenancio DATVenancio marked this pull request as ready for review June 12, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants