Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3014 #3015

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Issue 3014 #3015

merged 5 commits into from
Sep 6, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Aug 31, 2023

I am preparing an update to our Project Team pages.

  • Add new role - type: - publishing-assistant + labels and definitions
  • Add loop for publishing-assistant

--

  • I'll check the build
  • Next, I'll seek input from the team to check/adjust my translations

Closes #3014

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Add new role - type: - publishing-assistant + labels and definitions
Add loop for publishing-assistant
@anisa-hawes anisa-hawes self-assigned this Aug 31, 2023
@anisa-hawes
Copy link
Contributor Author

Hello @marie-flesch, @DanielAlvesLABDH, and @jenniferisasi

May I ask for your help to check my translation of this new team role for Publishing Assistant?

- type: publishing-assistant 
  label:
    en: Publishing Assistant
    es: Asistente de publicaciones
    fr: Assistante de publication
    pt: Assistente de publicações
  definition:
    en: Supports our publishing workflow
    es: Apoya nuestro proceso de publicación
    fr: Soutien à notre processus de publication
    pt: Apoia o nosso processo de publicação

Let me know if any corrections are needed? If you prefer, you can edit the teamroles.yml file in this branch, or leave a comment here and I can make any adjustments you recommend.

Thank you.

@jenniferisasi
Copy link
Contributor

jenniferisasi commented Sep 1, 2023

Hola @anisa-hawes! I think, to me, using the singular also in ES and PT sounds better "Asistente de publicación" and "Assistente de publicação" @DanielAlvesLABDH what do you think?

(not making any changes cos this is not a terrible change in meaning)

@DanielAlvesLABDH
Copy link
Contributor

Dear @anisa-hawes and @jenniferisasi I agree that "Assistente de publicação" is better. Thanks

jenniferisasi and others added 2 commits September 1, 2023 11:23
Making ES and PT singular for publishing assistant
editing French translation of "publishing assistant"
@anisa-hawes anisa-hawes merged commit a10b41a into gh-pages Sep 6, 2023
5 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3014 branch September 6, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparing for an update to our Project Team pages
5 participants