Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3048 #3049

Merged
merged 12 commits into from
Nov 3, 2023
Merged

Issue 3048 #3049

merged 12 commits into from
Nov 3, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Oct 19, 2023

I'm updating the contact email address provided across our /en/individual, /es/donaciones, /fr/dons, /pt/doacoes pages, so that initial enquiries about making individual donations to the project are directed to my admin@ email address.

Closes #3048

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Update email contact, line 36.
Update email contact, line 35.
Update email contact, line 35.
Update email contact, line 36.
Update email contact, line 36.
Update email contact, line 36.
@anisa-hawes
Copy link
Contributor Author

Hello @charlottejmc,

Could you help me with a review?

Please take a look at the changes I've made to the files, then double-check these pages /en/individual, /es/donaciones, /fr/dons, /pt/doacoes pages in the Netlify Preview to make sure everything displays as it should.

If you agree with me that this is good and ready to merge, you can Approve!

Thank you. A

charlottejmc
charlottejmc previously approved these changes Oct 19, 2023
Copy link
Contributor

@charlottejmc charlottejmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anisa, this all looks great on my end!

I just noticed that the syntax for the links is html for all languages but PT, where it is in markdown. Is this coincidental, or is there a reason for the difference?

@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Oct 19, 2023

Thank you, @charlottejmc. Yes, I noticed that too.

I wonder if we could make a slight adjustment? It would be good if we could embed the mailto: link so that the text displayed isn't the email address itself (but rather the 'write to us', 'send us an email' part of the sentences). We can format this using Markdown syntax across all four pages.

For EN, it could be:

For donations via bank transfer and cheque, we’d be grateful if you could [write to us](mailto:[email protected]) to let us know who you are and why you’ve chosen to support our work.

Note that we'd need to delete the word 'at' in this case ^ (at the moment, it reads write to us at)

For ES:

En caso de donativos por transferencia bancaria o cheque, solicitamos que [envíes un correo](mailto:[email protected]) para que nos cuentes sobre ti y por qué decidiste apoyar nuestro trabajo.

FR, I will let you take care of that one 😉

and for PT:

Para doações através de transferência bancária e cheque, ficaríamos gratos se [escrevesse o e-mail](mailto:[email protected]) para sabermos quem é e por que decidiu apoiar o nosso trabalho.

(I think that's right 🤔 ... I adjusted ficaríamos gratos se escrevesse para o e-mail to ficaríamos gratos se escrevesse o e-mail but we can check with the PT team!)

Embed email address using markdown
charlottejmc and others added 5 commits October 27, 2023 14:03
Embed email address using markdown
Embed email address
Embed email address
Remove full stop
@anisa-hawes anisa-hawes merged commit 33f686c into gh-pages Nov 3, 2023
4 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3048 branch November 3, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small update to our /en/individual, /es/donaciones, /fr/dons, /pt/doacoes pages
2 participants