Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload corpus-analysis-with-spacy.ipynb #3051

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Upload corpus-analysis-with-spacy.ipynb #3051

merged 1 commit into from
Oct 19, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Oct 19, 2023

Upload /assets directory for corpus-analysis-with-spacy containing .ipynb file.

Closes #3050

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • [ ] Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Upload python notebook into /assets directory
@anisa-hawes anisa-hawes self-assigned this Oct 19, 2023
@anisa-hawes
Copy link
Contributor Author

(I checked the link which was flagged as broken https://issuu.com/ralcaraz/docs/omeka-manual but it is live and seems fine so I've initiated a re-run of the build)

@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Oct 19, 2023

Salut @charlottejmc,

May I ask you to help me with another review?

As I explained yesterday, we've recently developed a workflow for handling python notebooks associated with our lessons. We need to create a preliminary PR to upload Megan's .ipynb to Jekyll before Alex and I can move forwards with preparing the PR to publish the lesson. This is so that the link to the asset (which will be rendered with nbviewer) is already live – if not, it would cause a broken link build error.

You can see that I've uploaded the /asset directory with the notebook inside it. But in this case, there's nothing to see in the Preview.

Thank you.

@anisa-hawes anisa-hawes merged commit fc12740 into gh-pages Oct 19, 2023
5 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3050 branch October 19, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Python notebook to /assets
2 participants