Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update creacion-de-aplicacion-shiny.md #3065

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Update creacion-de-aplicacion-shiny.md #3065

merged 2 commits into from
Nov 10, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Nov 10, 2023

I'm replacing two instances of a broken link in es/lecciones/creacion-de-aplicacion-shiny.

The problem link is: https://datos.gob.es/es/catalogo/ea0019768-hemeroteca-digital-listado
I've replaced it at lines 85 and 507, with perma.cc links.

Closes #3063

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Replace broken links at lines 85 and 507.
@anisa-hawes
Copy link
Contributor Author

anisa-hawes commented Nov 10, 2023

Hola @jenniferisasi. Do you have a moment to review this PR for me?

Do you think that my suggested replaced links (both now perma.cc) make sense?

@jenniferisasi
Copy link
Contributor

Sure thing, @anisa-hawes! In checking the previous links (that don't work now), we need the same perma-link in both, the one with the list of titles: https://perma.cc/JT88-ZXPD

@anisa-hawes
Copy link
Contributor Author

Thank you, @jenniferisasi. I'll make that adjustment.

Copy link
Contributor

@jenniferisasi jenniferisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

Copy link
Contributor

@jenniferisasi jenniferisasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! approved

@anisa-hawes anisa-hawes merged commit ecdcf4a into gh-pages Nov 10, 2023
5 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3063 branch November 10, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace broken link in es/lecciones/creacion-de-aplicacion-shiny
2 participants