Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3072 #3073

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Issue 3072 #3073

merged 5 commits into from
Nov 17, 2023

Conversation

anisa-hawes
Copy link
Contributor

@anisa-hawes anisa-hawes commented Nov 16, 2023

I'm removing a live vacancy from /en/vacancies, /es/vacantes, /fr/postes-vacants, and /pt/vagas.

I'm replacing the advertisement text with a holding message on each page, (as before, so these translations have been checked).

Closes #3072

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Revert to holding message.
Revert to holding message.
Revert to holding message.
Revert to holding message.
Copy link
Contributor

@charlottejmc charlottejmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anisa, I have one small comment about the message in French, which reads "Merci de l’intérêt que vous portez au Programming Historian."

From what I understand, using "merci [de]" in front of a noun is not officially incorrect, but we do usually prefer "merci [pour]".

It would sound more natural for me to read "Merci pour l’intérêt que vous portez au Programming Historian."

I have approved it though, because it's still correct as it is currently, and perhaps more a matter of preference!

charlottejmc
charlottejmc previously approved these changes Nov 17, 2023
Adjust translation.
@anisa-hawes anisa-hawes merged commit 8065902 into gh-pages Nov 17, 2023
5 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3072 branch November 17, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove call for editors from /en/vacancies, /es/vacantes, /fr/postes-vacants, and /pt/vagas
2 participants