Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3078 #3079

Merged
merged 12 commits into from
Nov 23, 2023
Merged

Issue 3078 #3079

merged 12 commits into from
Nov 23, 2023

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Nov 17, 2023

I've replaced the outdated event in our /en/events, /es/eventos, /fr/manifestations and /pt/eventos pages with a suggestion for a new holding message, to display when we do not have any events to announce.

I have listed the outdated event instead in our /en/research, /es/investigacion, /fr/recherche and /pt/pesquisa pages.

Closes #3078

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Remove outdated event
Suggest holding message
Remove outdated event
Suggest holding message
Remove outdated event
Suggest holding message
Remove outdated event
Suggest holding message
Update brasil
Update Brazil
@charlottejmc
Copy link
Contributor Author

Hello @jenniferisasi and @DanielAlvesLABDH,

I have updated our events pages with a suggestion for a "holding message" to display when we don't have any events to announce. I wonder whether you might have a moment to check my translation in Spanish and Portuguese?

I have translated it from English:

Thank you for your interest in our events calendar. We don’t have anything scheduled right now, but come back soon to stay updated!

To Spanish:

Gracias por su interés en nuestro calendario de eventos. De momento no tenemos nada planeado, pero vuelva pronto para informarse!

And Portuguese:

Obrigado pelo seu interesse no nosso calendário de eventos. De momento, não temos nada programado, mas volte em breve para se manter atualizado!

Feel free to simply comment here if that is less time-consuming for you. I can then update the branch.

Thank you very much!

@jenniferisasi
Copy link
Contributor

Thank you @charlottejmc! On the ES version, the last sentence sounds a bit odd to me, maybe something like "No tenemos nada programado en este momento, ¡pero regresa pronto para mantenerte actualizado!" or "mantenerte al día!" :)

Update translation
@charlottejmc
Copy link
Contributor Author

Thank you very much @jenniferisasi, I've made that change now.

Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olá @charlottejmc. Thank you for working on this.

Noting here: Daniel confirmed by email that the PT holding statement you've prepared reads well 🙂 So I'm happy to approve this.

@charlottejmc charlottejmc merged commit cb75c2b into gh-pages Nov 23, 2023
5 checks passed
@charlottejmc charlottejmc deleted the Issue-3078 branch November 23, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove past event from Upcoming Events list
3 participants