Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3086 #3087

Merged
merged 10 commits into from
Nov 24, 2023
Merged

Issue 3086 #3087

merged 10 commits into from
Nov 24, 2023

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Nov 22, 2023

I have made changes to two of the French terms used on the website:

Manifestations is now Événements.

"Vous pouvez faire une donation" is now "Vous pouvez faire un don !".

Closes #3086

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Assistant @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • [ ] if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Replace Manifestations with Evenements
Replace Donation with Don
Change Manifestations to Événements
Rename file to Événements
@charlottejmc
Copy link
Contributor Author

Bonsoir @marie-flesch,

I have made the changes we spoke about by email. I would be very grateful if you could check the Netflify preview on your end, and approve the changes if you are happy with them!

Thank you very much ✨

@marie-flesch
Copy link
Contributor

Awesome @charlottejmc! Just a small change : "Évènements" (new spelling) instead of "Événements" (old spelling), both times it appears. New spelling is consistent with pronunciation while the older one is not :)

Change to new spelling
Change to new spelling
@charlottejmc
Copy link
Contributor Author

Thanks @marie-flesch, I've made that change now!

anisa-hawes
anisa-hawes previously approved these changes Nov 23, 2023
Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charlottejmc!

As Marie has given her review via a comment (and you've implemented the adjustment she suggested), I'm happy to approve this.

Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @marie-flesch has already reviewed this via a comment (and you've implemented the adjustment she suggested), I'm happy to approve this.

@charlottejmc charlottejmc merged commit 5d6042e into gh-pages Nov 24, 2023
5 checks passed
@charlottejmc charlottejmc deleted the Issue-3086 branch November 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update French translations
3 participants