Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3254 #3255

Merged
merged 36 commits into from
May 10, 2024
Merged

Issue 3254 #3255

merged 36 commits into from
May 10, 2024

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented May 9, 2024

I've now added a warning box at the start of every lesson listed in Issue #3169 which were marked as needing minor or major changes. (The remaining lessons reference the Old Bailey Website, but don't actually rely on it to work.)

Closes #3254

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Add warning box
@charlottejmc charlottejmc requested a review from anisa-hawes May 10, 2024 10:43
Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @charlottejmc. Thank you for preparing these warning boxes for us, and collaborating with the MEs to coordinate translations.

Thank you to @hawc2, @jenniferisasi, @marie-flesch and @ericbrasiln for supporting us. Tagging each of you here to confirm that the warning boxes are now in place.

I've visually checked the previews for each lesson we've applied the warning message to, and I'm happy to approve this PR.

@charlottejmc charlottejmc merged commit e7550d9 into gh-pages May 10, 2024
5 checks passed
@charlottejmc charlottejmc deleted the Issue-3254 branch May 10, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a warning box for all lessons using the Old Bailey Online website
2 participants