Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3396 #3401

Merged
merged 8 commits into from
Dec 5, 2024
Merged

Issue 3396 #3401

merged 8 commits into from
Dec 5, 2024

Conversation

charlottejmc
Copy link
Contributor

@charlottejmc charlottejmc commented Nov 7, 2024

I have updated the link to download Komodo Edit across the en, es, fr and pt versions.

Closes #3396

Checklist

  • Assign yourself in the "Assignees" menu
  • Add the appropriate "Label"
  • If this PR closes an Issue, add the phrase Closes #ISSUENUMBER to your summary above
  • Ensure the status checks pass: if you have difficulty fixing build errors, please contact our Publishing Manager @anisa-hawes
  • Check the Netlify Preview: navigate to netlify/ph-preview/deploy-preview and click 'details' (at right)
  • Assign at least one individual or team to "Reviewers"
    • if the text needs to be translated, please follow the translation request guidelines, then assign the relevant language team(s) as "Reviewers" and tag both the team as well as the managing editor in your PR.

Update Komodo Edit download link
Update Komodo Edit download link
Update Komodo Edit download link
Update Komodo Edit download link
@charlottejmc
Copy link
Contributor Author

Hi @hawc2, I've requested your review for this PR which hopefully solves the problem flagged by an external contributor, which James has shared in Issue #3396. The download is a bit slow on my end, but it works. Let me know if you think this fix is enough to close the related issue!

@anisa-hawes
Copy link
Contributor

Hello @hawc2,

You'll note that Charlotte has updated the download links to make things clearer. I'm satisfied that this resolves the immediate problem, and the lessons remain usable for now.

Let's continue the conversation about how we decide which lessons can be maintained and which should be retired.

Thank you. A.

@hawc2
Copy link
Contributor

hawc2 commented Nov 7, 2024

Thanks @anisa-hawes and @charlottejmc. This looks like a good fix.

With that said, I don't know if it is as simple as replacing every mention of the Komodo Website with the Active State Website. They're very different kinds of websites and it may be worth alerting the reader to that. The link currently provided doesn't bring up a website, it just downloads the file. I wonder if we could link to the Active State website with this link, and then provide in addition the specific download link.

https://downloads.activestate.com/Komodo/releases/12.0.1/

This gives the reader some context what they're downloading. I also think it's best practice to tell the reader what the Active State site is, a place for hosting open source software it seems. If I we're reading this I'd be worried Active State is not a real website and I might be downloading a virus or something. I had never heard of it before now.

Did the Komodo website shut down entirely? Is it worth adding a brief note about this change and why it's happening? Has Komodo been sunset? This context seems important to provide for the reader with a sense of how it works in 2024.

Additional clarifications about Komodo Edit
@charlottejmc
Copy link
Contributor Author

charlottejmc commented Nov 12, 2024

Thank you for your notes, @hawc2!

I've made some further edits to address your points, which I think are indeed important.

I made the download link more explicit, and also linked directly to ActiveState (they are the developers behind Komodo Edit, apparently!).

In the warning box I added, I linked to this blog post which explains why ActiveState decided to retire Komodo Edit (and Komodo IDE). Hopefully this should provide some helpful context.

I also suggested readers use a different programme instead – would you agree?

If you agree to these changes, I can coordinate the translations into the other languages.

hawc2
hawc2 previously approved these changes Nov 19, 2024
@charlottejmc
Copy link
Contributor Author

charlottejmc commented Nov 20, 2024

Hello @jenniferisasi and @ericbrasiln, I've made some changes to the EN original lesson, because Komodo Edit has been retired (although it's still usable). I've made the new download link easier to find, and I've added a warning box which tells readers that it's probably best to use another option if they can.

Would you kindly be able to translate my changes (or coordinate their translation!) into ES and PT? You'll see in the files changed tab that I've made an edit to both your files already, but you can ignore that commit, and use my EN/FR changes as an example instead.

Thank you very much for your help 😊

Komodo Edit clarifications + warning box
@ericbrasiln
Copy link
Member

Hello @charlottejmc,

Thank you for the update! I've included the changes in the Portuguese lesson file in the Issue-3396 branch. Please let me know if there’s anything else I can help with.

@charlottejmc
Copy link
Contributor Author

Super! Obrigada, @ericbrasiln.

Translated section on Installing Komodo Edit into Spanish
@jenniferisasi
Copy link
Contributor

Sorry for my delay @charlottejmc! I have just translated the two paragraphs into Spanish - and hopefully the checks will run to be ready to merge.

@anisa-hawes
Copy link
Contributor

Hello all,

The broken links blocking this build are under investigation in #3413 !

@charlottejmc
Copy link
Contributor Author

Thank you @jenniferisasi for the translation! The broken links are now working again, so this PR is ready to merge 🎉

Copy link
Contributor

@anisa-hawes anisa-hawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for coordinating @charlottejmc! And thanks to all for their translations and contributions.

@anisa-hawes anisa-hawes merged commit 1fd6f97 into gh-pages Dec 5, 2024
5 checks passed
@anisa-hawes anisa-hawes deleted the Issue-3396 branch December 5, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential issue with Setting Up an Integrated Development Environment for Python (Windows)
5 participants