-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ergo: Create MySQL subprocess instead of using external DB #170
base: master
Are you sure you want to change the base?
Conversation
This statement was a no-op, given the value defined in BASE_CONFIG
This starts each test with a clean database, so we can remove chan/nick randomization from stateful tests (chathistory and roleplay). It will also allow testing Ergo with a MySQL backend for the KV store instead of buntdb. Additionally, this makes it much easier to run these tests, than having to manually configure such a database.
0e1ea42
to
8bd102a
Compare
This works on my system now, but is extremely slow: total Ergo suite execution time goes from 30s to 4m30s. It seems to me like this negates any advantage in convenience from not having to set up one's own database. Maybe we could add an ergo subcommand that truncates the MySQL-backed KV store? It could take a randomly generated confirmation code to guard against accident. |
Mount a tmpfs on |
This wouldn't support running tests in parallel. It's not a big deal with Ergo at the moment, but still speeds up the test suite on my machine |
actually, this would work, I would just need to setup per-process databases |
In #176 I solved this by configuring the controlled process to use a different table prefix on every run. |
This starts each test with a clean database, so we can remove chan/nick
randomization from stateful tests (chathistory and roleplay).
It will also allow testing Ergo with a MySQL backend for the KV store
instead of buntdb.
Additionally, this makes it much easier to run these tests, than having
to manually configure such a database.