Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests for local version with discovery handlers #648

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:
This fixes an issue with the new e2e tests framework that got missed during review, it makes the e2e tests to fail for all new PRs (saw that with #533 )

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@diconico07 diconico07 merged commit bc24639 into project-akri:main Sep 12, 2023
16 checks passed
@diconico07 diconico07 deleted the fix-e2e-tests-dh-versions branch September 12, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants