Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use valid format for dummy uris connect through UDS channel #668

Merged

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Oct 12, 2023

What this PR does / why we need it:
This PR change the uri used in gRPC clients for UDS channel. Original uri is http://[::]:50051 which is rejected by some gRPC servers due to the uri header is invalid. Change the uri to http://[::1]:50051 fixes the problem.

closes #667

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih johnsonshih merged commit 12e66e7 into project-akri:main Oct 19, 2023
48 checks passed
@johnsonshih johnsonshih deleted the user/jshih/uds-grpc-client-address branch October 19, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transport error when Agent calls gRPC discover() to some Discovery Handlers
2 participants