Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues #676

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Fix build issues #676

merged 4 commits into from
Nov 16, 2023

Conversation

diconico07
Copy link
Contributor

What this PR does / why we need it:

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@kate-goldenring kate-goldenring dismissed their stale review October 27, 2023 15:45

didn't notice failing CI

@diconico07
Copy link
Contributor Author

The CI is failing because I forgot to add the if push or release condition to one of the login step. These are needed as the credentials are not available to PR jobs.
I'll do this as soon as I get back to a computer.

@kate-goldenring
Copy link
Contributor

@diconico07 need one more version bump as i just merged #675

Signed-off-by: Nicolas Belouin <[email protected]>
@diconico07 diconico07 merged commit 0e834a6 into project-akri:main Nov 16, 2023
35 checks passed
@diconico07 diconico07 deleted the fix-build-issues branch November 16, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants