Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource Type Rewrite #47

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from
Open

Resource Type Rewrite #47

wants to merge 48 commits into from

Conversation

jkunstwald
Copy link
Contributor

  • Breaking: Remove in-line description/info field from resource types

    • These infos are now accessed via the PHI backend whenever required
    • pr::buffer and pr::texture are now both just as small as phi::handle::resource at 4 byte
    • Simplifies storage, makes view types like phi::buffer_address etc. simpler
    • While the .info field wasn't explicitly public API, it is a breaking change nonetheless

  • Add cache freeing after frame submit

    • Frame: free_to_cache_after_submit

  • Make vertex and index offsets arguments to all Frame draw methods

    • remove Frame set_offset

jkunstwald added 26 commits June 12, 2021 15:58
@jkunstwald
Enable /WX in MSVC
8761936
@jkunstwald
Fix warnings, fix index stride assert
151d1bb
@jkunstwald
Add support for acceleration structures in cached arguments
54a3605
@jkunstwald
Merge branch 'kw/develop' of github.com:project-arcana/phantasm-rende…
b3abc94 
…rer into kw/develop
@jkunstwald
Minor change
ff2b9ca
@jkunstwald
Add make_backend to dll surface
8451e4a
@jkunstwald
Add optional src MIP and array elem on copy tex-to-buffer
0d9aaa8
@jkunstwald
Fix upload_texture_subresource regarding destination array element
7802ffa
@jkunstwald
Add Frame::consume_other_frame
c0817bf
@jkunstwald
Adapt to phi changes
81d0943
@jkunstwald
Minor changes
d6c2327
@jkunstwald
No longer query timestamp frequency during startup
2b87011
@jkunstwald
Fix warnings
70caa71
@jkunstwald
Adapt to rlog api
09106f8
@jkunstwald
Add detailed copy texture-to-buffer overload
b9894cf
@jkunstwald
Add rv helper for byte address buffers, add dispatch helpers with gro…
0ab52ed 
…up sizes
@jkunstwald
Add bind overloads for phi::buffer_address
2391617
@jkunstwald
Add framebuffer_info method to directly set a config
4e9bc0e
@jkunstwald
Adapt to PHI changes
65ac934
@jkunstwald
Adapt to DXCW changes
9cb82a6
@jkunstwald
Adapt to DXCW changes
c388e8b
@jkunstwald
Frame: add dispatch1D
653f0e2
@jkunstwald
Adapt to pending PHI changes regarding config structs
003769f
@jkunstwald
Use texture upload utilities in PHI
7b344be
@jkunstwald
Adapt to cc allocator location change
21bd9a4
@jkunstwald
Fix usage of calculate_texture_upload_size when using the existing mi…
22b8768 
…p amount
@jkunstwald jkunstwald marked this pull request as ready for review February 23, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Trettner Philip-Trettner Awaiting requested review from Philip-Trettner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkunstwald @cetigo