Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the use of asgard as a library #703

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

mkstoyanov
Copy link
Collaborator

@mkstoyanov mkstoyanov commented Jul 19, 2024

Major change in the build system and the potential usage:

  • ASGarD can not be build and installed as a stand-alone library

    • does not work with custom build BLAS and HDF5, must use external installations
    • requires the -DCMAKE_INSTALL_PREFIX else it defaults to /usr/local and that's not desirable
  • the installation can be tested with make test_install

  • an ASGarD installation can be included in separate project

  • the users have the ability to create a new PDE that exists outside of the main library

  • for both cases, see the examples and specifically those in <CMAKE_INSTALL_PREFIX>/share/asgard/exmaples

PS: The install prefix defaults to <build-folder>/asgard_install/ to avoid issues with the system files in /usr/local

@mkstoyanov mkstoyanov requested a review from quantumsteve July 19, 2024 21:00
@mkstoyanov
Copy link
Collaborator Author

mkstoyanov commented Jul 19, 2024

@quantumsteve We should add -DASGARD_BUILD_HDF5=ON to the failing build. I don't want ASGarD to build large third party projects unless the user explicitly asks for that.

I also want to figure out how to "install" the build HDF5 (and OpenBLAS) but that will take a while as I have to test build those a few times. I want to keep the project rolling, so if it takes too long, I will add the HDF5 install in another PR.

PS: The code can now install both HDF5 and OpenBLAS.

@mkstoyanov
Copy link
Collaborator Author

@stefan-schnake Take a look at the "example" of continuity2d and see if my language is fitting what we want to do.

Also, this may help a lot with your work.

@mkstoyanov mkstoyanov force-pushed the allow_external_pdes branch from 13977e4 to 6d4fd64 Compare July 21, 2024 17:57
@mkstoyanov mkstoyanov force-pushed the allow_external_pdes branch from 6d4fd64 to 6660980 Compare July 23, 2024 15:48
@quantumsteve
Copy link
Collaborator

@quantumsteve We should add -DASGARD_BUILD_HDF5=ON to the failing build. I don't want ASGarD to build large third party projects unless the user explicitly asks for that.

buildscript's updated.

src/pde.hpp Outdated Show resolved Hide resolved
@mkstoyanov mkstoyanov force-pushed the allow_external_pdes branch from ac76856 to a36c6aa Compare July 23, 2024 21:21
@mkstoyanov mkstoyanov mentioned this pull request Jul 23, 2024
@mkstoyanov mkstoyanov merged commit 6d64b39 into project-asgard:develop Jul 29, 2024
11 checks passed
@mkstoyanov mkstoyanov deleted the allow_external_pdes branch July 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants