Skip to content

Commit

Permalink
Add a comment regarding status ... I did not update the logic but it …
Browse files Browse the repository at this point in the history
…does seem wrong
  • Loading branch information
andreilitvin committed Oct 29, 2024
1 parent b88af47 commit 9ceda24
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/app/clusters/scenes-server/scenes-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ CHIP_ERROR AddResponseOnError(CommandHandlerInterface::HandlerContext & ctx, Res
template <typename ResponseType>
CHIP_ERROR AddResponseOnError(CommandHandlerInterface::HandlerContext & ctx, ResponseType & resp, Status status)
{
// TODO: this seems odd: we convert `status` to a CHIP_ERROR and then back to status. This seems
// potentially lossy and not ideal.
return AddResponseOnError(ctx, resp, StatusIB(status).ToChipError());
}

Expand Down

0 comments on commit 9ceda24

Please sign in to comment.