Skip to content

Commit

Permalink
Update TC_CADMIN_1_19.py
Browse files Browse the repository at this point in the history
- Moved location of print_step to top of for range for creating virtual fragments
- Removed unnecessary print_step for catching error
  • Loading branch information
j-ororke authored Oct 29, 2024
1 parent a9f2650 commit b2e6dd5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/python_testing/TC_CADMIN_1_19.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ async def test_TC_CADMIN_1_19(self):
fids = {}
self.print_step("total fabrics", max_fabrics - initial_number_of_fabrics)
for fid in range(1, max_fabrics - initial_number_of_fabrics):
self.print_step("commissioning iteration", fid)
# Make sure that current test step is 5, resets here after each loop
self.current_step_index = 5

Expand All @@ -122,8 +123,6 @@ async def test_TC_CADMIN_1_19(self):
nodeId=self.dut_node_id, setupPinCode=params.commissioningParameters.setupPinCode,
filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=params.randomDiscriminator)

self.print_step("commissioning iteration", fid)

self.step(6)
# TH reads the CommissionedFabrics attributes from the Node Operational Credentials cluster
current_fabrics = await self.read_single_attribute_check_success(dev_ctrl=self.th1, fabric_filtered=False, endpoint=0, cluster=OC_cluster, attribute=OC_cluster.Attributes.SupportedFabrics)
Expand All @@ -145,7 +144,6 @@ async def test_TC_CADMIN_1_19(self):
filterType=ChipDeviceCtrl.DiscoveryFilterType.LONG_DISCRIMINATOR, filter=params.randomDiscriminator)

except ChipStackError as e:
self.print_step("err", e.err)
# When attempting to create a new controller we are expected to get the following response:
# src/credentials/FabricTable.cpp:833: CHIP Error 0x0000000B: No memory
# Since the FabricTable is full and unable to create any new fabrics
Expand Down

0 comments on commit b2e6dd5

Please sign in to comment.