[icd] Add steps for checking ICD during commissioning #29427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29427: Size comparison from 33052cc to a4674cc Increases (4 builds for linux, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #29427: Size comparison from 33052cc to a2e6e9c Increases above 0.2%:
Increases (26 builds for bl602, bl702, bl702l, cc13x4_26x4, cyw30739, k32w, linux, qpg, telink)
Decreases (13 builds for bl702, esp32, linux, nrfconnect, psoc6, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple and
kkasperczyk-no
pullapprove
bot
requested review from
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #29427: Size comparison from d1fa6ee to be930c5 Increases (4 builds for linux, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #29427: Size comparison from d1fa6ee to c214394 Increases (4 builds for linux, telink)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@erjiaqing from today's meeting, we conclude that "Add ICD Feature read over PASE before AddNoc. Bundle together with other attributes being read at that time, such as BasicInfo, OperationalCredentialsCluster, NetworkProvisioningCluster , etc." |
yunhanw-google
requested review from
yunhanw-google,
mkardous-silabs and
bzbarsky-apple
mkardous-silabs
approved these changes
Oct 25, 2023
yunhanw-google
approved these changes
Oct 25, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…9427) * [icd] Add steps for checking ICD during commissioning * Add TODO for attribute used & rename stage to IcdIdentification * Update * Fix -- missing endpoint * Update * Update * Update * Fix * Fix * ReadCommissioningInfo2 may complete with enpty report
| @@ -106,6 +106,8 @@ class AutoCommissioner : public CommissioningDelegate | |||
| ReadCommissioningInfo mDeviceCommissioningInfo; | |||
| bool mNeedsDST = false; | |||
|
|
|||
| bool mNeedIcdRegistraion = false; | |||
There was a problem hiding this comment.
Please name this mNeedICDRegistration.
| info.isIcd = true; | ||
| info.checkInProtocolSupport = !!(featureMap & to_underlying(IcdManagement::Feature::kCheckInProtocolSupport)); | ||
| } | ||
| else if (err == CHIP_ERROR_KEY_NOT_FOUND) |
There was a problem hiding this comment.
So this would be a case of a non-spec-compliant server that did not respond at all to a non-wildcard path?
Please document exactly why this case is here, because it's not obvious to readers how this situation could happen.
And perhaps this case should just lead comissioning to fail, just like an error other than UnsupportedCluster causes it to fail?
| @@ -71,6 +71,13 @@ enum CommissioningStage : uint8_t | |||
| kNeedsNetworkCreds, | |||
| }; | |||
|
|
|||
| enum ICDRegistrationStrategy : uint8_t | |||
There was a problem hiding this comment.
Why is this not an enum class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29382
kIcdDiscoverystage during commissioningmIcdRegistrationStrategyfor commissioning params, withkIgnoreandkBeforeComplete,kBeforeCompleteshould be used for self-registration or external controller registration.Tests: WIP, to be added in future PRs