-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bridge app to init network commissioning #29612
Merged
mergify
merged 2 commits into
project-chip:master
from
yhoyoon:feature/contribution-certificate
Oct 10, 2023
Merged
Update bridge app to init network commissioning #29612
mergify
merged 2 commits into
project-chip:master
from
yhoyoon:feature/contribution-certificate
Oct 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the linux bridge app to initialize the Network Commissioning cluster, so that the FeatureMap of the cluster is set to ethernet. In other Linux example apps, the FeatureMap of the Network Commissioning cluster is set to ethernet, but in the bridge app, the cluster is not initialized, so the FeatureMap is set to thread. The default value of the FeatureMap is thread in zap file of example apps. Signed-off-by: Youngho Yoon <[email protected]>
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
October 6, 2023 04:36
pullapprove
bot
requested review from
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
October 6, 2023 04:36
PR #29612: Size comparison from f4c2094 to adb67d9 Increases (1 build for linux)
Decreases (1 build for telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I didn't realize we had Linux examples that did not call
Signed-off-by: Youngho Yoon <[email protected]>
bzbarsky-apple
approved these changes
Oct 10, 2023
andy31415
approved these changes
Oct 10, 2023
saurabhst
approved these changes
Oct 10, 2023
jmartinez-silabs
approved these changes
Oct 10, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Update bridge app to init network commissioning This change modifies the linux bridge app to initialize the Network Commissioning cluster, so that the FeatureMap of the cluster is set to ethernet. In other Linux example apps, the FeatureMap of the Network Commissioning cluster is set to ethernet, but in the bridge app, the cluster is not initialized, so the FeatureMap is set to thread. The default value of the FeatureMap is thread in zap file of example apps. Signed-off-by: Youngho Yoon <[email protected]> * Move the setup code into ApplicationInit Signed-off-by: Youngho Yoon <[email protected]> --------- Signed-off-by: Youngho Yoon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the linux bridge app to initialize the Network Commissioning cluster, so that the FeatureMap of the cluster is set to ethernet.
In other Linux example apps, the FeatureMap of the Network Commissioning cluster is set to ethernet, but in the bridge app, the cluster is not initialized, so the FeatureMap is set to thread. The default value of the FeatureMap is thread in zap file of example apps.