-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename AlarmMap -> AlarmBitmap in-line with a proposed spec name change #29670
Conversation
In line with CHIP-Specifications/connectedhomeip-spec#7628. This commit hits the .xml and .zap files only.
…nd in the all-clusters-app
PR #29670: Size comparison from 43159a8 to 611825d Increases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Looks like there is a lot of additional changes from "ram" to "callback", is this intentional? |
That looks like tip ZAP was used instead of the ZAP version the SDK is currently pinned at (v2023.10.04-nightly). |
Yeah that was the problem. However, given where we are in the release process and given the nature of the change, I'm going to close out this pull request and the associated issue as "won't fix" |
Queuing up a change in so that we have it in hand in case we take the spec change.