-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Split BLE helper into separate class files #29722
Conversation
PR #29722: Size comparison from ffd1571 to c138d90 Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
PR #29722: Size comparison from 3a66fef to 2f0c467 Increases above 0.2%:
Increases (10 builds for linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving: this looks like a move-around of things, so even my comments could be resolved as a followup.
@andy31415 I'll try to address all your comments as a followup. I didn't want to make a lot of noise in this PR, so in next PR(s) it will be clear what is changed and what not. All static functions will be moved to classes as private functions (some of them will remain static). This will eliminate the need of passing pointers back and forth. |
Problem
The Helper.cpp file contains two distinct object types which could be wrapped into separate classes (as a followup PR), which should significantly improve readability and maintainability.
Changes
This PR does not change any logic behind moved functions. It's a simple ctrl-c ctrl-v operation, plus small fixes in includes.
BluezConnection
related functions to BluezConnection.cppBluezEndpoint
related functions to BluezEndpoint.cppTesting
Locally tested with BLE-WiFi commissioning.
CI will test potential build breaks.