-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OnOff cluster to match the spec #29946
Conversation
PR #29946: Size comparison from f74e95b to e19dfa4 Increases (12 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the spelling of Behavior in the spec instead.
More to the point: this already got renamed once; we can't easily rename it again.
Note also that the spec is already inconsistent: it calls it "Behavior" some places and "Behaviour" in others... |
To add to that, as far as I know, the proposed Vale rule would suggest "behavior". Kind of agree with Boris here that it might be better to adjust spec in this specific case. |
Almost sounds like we should just do a mass fix of this one and get it aligned on "behavior" 🤷🏼 |
PR #29946: Size comparison from 0db7c58 to 0a75ca9 Increases (15 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (7 builds for bl702, bl702l, cc32xx, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Changed type of variable from uint8 to enum8 (since it is an enum according to the spec).
Updated to revision 6 (added OffOnly feature)
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7776 matched the usage of Behavior/Behaviour.