-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: simplified android connection API #31617
Merged
sharadb-amazon
merged 8 commits into
project-chip:master
from
pgregorr-amazon:droid-conn-20231229
Jan 27, 2024
Merged
tv-casting-app: simplified android connection API #31617
sharadb-amazon
merged 8 commits into
project-chip:master
from
pgregorr-amazon:droid-conn-20231229
Jan 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 23, 2024 00:26
PR #31617: Size comparison from db7d887 to 313c7a0 Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
sharadb-amazon
requested changes
Jan 23, 2024
...s/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/support/EndpointFilter.java
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/java/com/chip/casting/app/MainActivity.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
...-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java
Outdated
Show resolved
Hide resolved
sharadb-amazon
approved these changes
Jan 24, 2024
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Show resolved
Hide resolved
hawk248
approved these changes
Jan 25, 2024
yunhanw-google
approved these changes
Jan 25, 2024
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Show resolved
Hide resolved
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
yunhanw-google
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you address the above comment, thanks
examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayer.java
Outdated
Show resolved
Hide resolved
yunhanw-google
approved these changes
Jan 26, 2024
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayer-JNI.cpp
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
January 26, 2024 22:54
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements and demonstrates the use of a simplified Casting Player connection API on Android. This simplified API delegates the work to the common connection implantation in C++ Native.
Change summary
Testing
Verified and tested locally with the Android tv-casting-app example app. The example app discovers Casting Players and is able to connect to the selected Casting Player.