Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dependency error and some changed requested by reviewer #34764

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

crlonxp
Copy link
Contributor

@crlonxp crlonxp commented Aug 3, 2024

  • Change the default setting of WiFiPAF as enabled if running on Linux system
  • Change to use C++ casting
  • Move the paf cancel function from destructor to shutdown

Copy link

Review changes with SemanticDiff.

Copy link

github-actions bot commented Oct 24, 2024

PR #34764: Size comparison from 75d7e6b to a7a761a

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 75d7e6b a7a761a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1350048 1350048 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647684 647684 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 825248 825248 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1054238 1054238 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 975022 975022 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829548 829548 0 0.0
RAM 123452 123452 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814856 814856 0 0.0
RAM 125332 125332 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761444 761444 0 0.0
RAM 113824 113824 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745688 745688 0 0.0
RAM 114016 114016 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617226 617226 0 0.0
RAM 205908 205908 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657194 657194 0 0.0
RAM 206060 206060 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678629 678629 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698473 698473 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698473 698473 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655409 655409 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615045 615045 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634673 634673 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634673 634673 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634317 634317 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654033 654033 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654033 654033 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609693 609693 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629553 629553 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629553 629553 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 925644 925644 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 742216 742216 0 0.0
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1018568 1018568 0 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1540020 1540020 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1550198 1550198 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781357 2781521 164 0.0
RAM 129520 129680 160 0.1
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6092442 6092606 164 0.0
RAM 523840 524000 160 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5423026 5423190 164 0.0
RAM 242416 242576 160 0.1
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4751606 4751770 164 0.0
RAM 218384 218544 160 0.1
chip-tool debug unknown 5960 5960 0 0.0
FLASH 13096042 13096116 74 0.0
RAM 584402 584402 0 0.0
chip-tool-ipv6only arm64 unknown 21408 21408 0 0.0
FLASH 11199624 11199656 32 0.0
RAM 635344 635344 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11355025 11355099 74 0.0
RAM 584890 584890 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4578190 4578324 134 0.0
RAM 205336 205496 160 0.1
fabric-sync debug unknown 4816 4816 0 0.0
FLASH 5290421 5290613 192 0.0
RAM 465416 465576 160 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5693777 5693905 128 0.0
RAM 228488 228648 160 0.1
lock-app debug unknown 5344 5344 0 0.0
FLASH 4801184 4801318 134 0.0
RAM 204472 204632 160 0.1
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4430454 4430588 134 0.0
RAM 198192 198352 160 0.1
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4569226 4569360 134 0.0
RAM 202760 202920 160 0.1
shell debug unknown 4216 4216 0 0.0
FLASH 3115981 3116141 160 0.0
RAM 160368 160528 160 0.1
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4163480 4163624 144 0.0
RAM 242896 243072 176 0.1
tv-app debug unknown 5624 5624 0 0.0
FLASH 6032501 6032693 192 0.0
RAM 596256 596416 160 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11300541 11300621 80 0.0
RAM 694536 694536 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 915564 915564 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 886048 886048 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848972 848972 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582424 582424 0 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596912 596912 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 619044 619044 0 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 683144 683144 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746696 746696 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647652 1647652 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553724 1553724 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1467988 1467988 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464964 1464964 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660544 660544 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618620 618620 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481920 481920 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 681138 681138 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620788 620788 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708768 708768 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625738 625738 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811748 811748 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1729948 1729948 0 0.0
RAM 90108 90108 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18237374 18237462 88 0.0
RAM 7946324 7946144 -180 -0.0

* Fix the problems in NANCancelPublish by using the incorrect type and id

Signed-off-by: Lo,Chin-Ran <[email protected]>
Copy link

github-actions bot commented Oct 29, 2024

PR #34764: Size comparison from c18a6de to d617481

Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c18a6de d617481 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1349984 1349984 0 0.0
RAM 104120 104120 0 0.0
bl702 lighting-app bl702+eth FLASH 647380 647380 0 0.0
RAM 25233 25233 0 0.0
bl702+wifi FLASH 824944 824944 0 0.0
RAM 13965 13965 0 0.0
bl706+mfd+rpc+littlefs FLASH 1053678 1053678 0 0.0
RAM 23821 23821 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 974462 974462 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 836412 836412 0 0.0
RAM 123676 123676 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 821832 821832 0 0.0
RAM 125556 125556 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 768404 768404 0 0.0
RAM 114048 114048 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 752664 752664 0 0.0
RAM 114240 114240 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 626506 626506 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 666482 666482 0 0.0
RAM 206284 206284 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678381 678381 0 0.0
RAM 78692 78692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698233 698233 0 0.0
RAM 81324 81324 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698233 698233 0 0.0
RAM 81324 81324 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655161 655161 0 0.0
RAM 73760 73760 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614829 614829 0 0.0
RAM 71644 71644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634457 634457 0 0.0
RAM 74196 74196 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634457 634457 0 0.0
RAM 74196 74196 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634181 634181 0 0.0
RAM 74692 74692 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653897 653897 0 0.0
RAM 77244 77244 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653897 653897 0 0.0
RAM 77244 77244 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609445 609445 0 0.0
RAM 68780 68780 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629297 629297 0 0.0
RAM 71412 71412 0 0.0
efr32 lock-app BRD4187C FLASH 926100 926100 0 0.0
RAM 159920 159920 0 0.0
BRD4338a FLASH 741256 741256 0 0.0
RAM 232580 232580 0 0.0
window-app BRD4187C FLASH 1018040 1018040 0 0.0
RAM 128264 128264 0 0.0
esp32 all-clusters-app c3devkit DRAM 95256 95256 0 0.0
FLASH 1538746 1538746 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116192 116192 0 0.0
FLASH 1548958 1548958 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2737039 2737203 164 0.0
RAM 129616 129776 160 0.1
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6039312 6039476 164 0.0
RAM 523872 524032 160 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5371938 5372102 164 0.0
RAM 242448 242608 160 0.1
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4705468 4705632 164 0.0
RAM 218416 218576 160 0.1
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12979326 12979400 74 0.0
RAM 584466 584466 0 0.0
chip-tool-ipv6only arm64 unknown 21416 21416 0 0.0
FLASH 11114536 11114568 32 0.0
RAM 635408 635408 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11309149 11309223 74 0.0
RAM 584954 584954 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4531898 4532032 134 0.0
RAM 205400 205560 160 0.1
fabric-sync debug unknown 4840 4840 0 0.0
FLASH 5244389 5244565 176 0.0
RAM 465448 465608 160 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5646593 5646721 128 0.0
RAM 228552 228712 160 0.1
lock-app debug unknown 5344 5344 0 0.0
FLASH 4754344 4754478 134 0.0
RAM 204536 204696 160 0.1
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4381116 4381250 134 0.0
RAM 198256 198416 160 0.1
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4520156 4520290 134 0.0
RAM 202824 202984 160 0.1
shell debug unknown 4216 4216 0 0.0
FLASH 3064061 3064237 176 0.0
RAM 160368 160528 160 0.1
thermostat-no-ble arm64 unknown 9456 9456 0 0.0
FLASH 4124152 4124296 144 0.0
RAM 242944 243120 176 0.1
tv-app debug unknown 5624 5624 0 0.0
FLASH 5980805 5980997 192 0.0
RAM 596320 596480 160 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 11187789 11187869 80 0.0
RAM 694568 694568 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914360 914360 0 0.0
RAM 143357 143357 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885896 885896 0 0.0
RAM 141496 141496 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847928 847928 0 0.0
RAM 142265 142265 0 0.0
nxp contact k32w0+release FLASH 582296 582296 0 0.0
RAM 71092 71092 0 0.0
mcxw71+release FLASH 596776 596776 0 0.0
RAM 63184 63184 0 0.0
light k32w0+release FLASH 618900 618900 0 0.0
RAM 70556 70556 0 0.0
k32w1+release FLASH 682992 682992 0 0.0
RAM 48816 48816 0 0.0
lock mcxw71+release FLASH 746576 746576 0 0.0
RAM 67340 67340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1643620 1643620 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1550588 1550588 0 0.0
RAM 209208 209208 0 0.0
light cy8ckit_062s2_43012 FLASH 1466564 1466564 0 0.0
RAM 201200 201200 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464004 1464004 0 0.0
RAM 225560 225560 0 0.0
qpg lighting-app qpg6105+debug FLASH 660392 660392 0 0.0
RAM 105420 105420 0 0.0
lock-app qpg6105+debug FLASH 618468 618468 0 0.0
RAM 99880 99880 0 0.0
stm32 light STM32WB5MM-DK FLASH 481680 481680 0 0.0
RAM 144844 144844 0 0.0
telink bridge-app tlsr9258a FLASH 680902 680902 0 0.0
RAM 91304 91304 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620500 620500 0 0.0
RAM 50600 50600 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708438 708438 0 0.0
RAM 73940 73940 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625344 625344 0 0.0
RAM 144468 144468 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811354 811354 0 0.0
RAM 99100 99100 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1722356 1722356 0 0.0
RAM 90140 90140 0 0.0
chip-tool-ubsan arm unknown 10792 10792 0 0.0
FLASH 18157782 18157854 72 0.0
RAM 7915456 7915276 -180 -0.0

@@ -154,6 +154,10 @@ static_library("Linux") {
if (chip_enable_ble) {
public_deps += [ "dbus/bluez" ]
}

if (chip_device_config_enable_wifipaf) {
public_deps += [ "${chip_root}/src/wifipaf:wifipaf" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public_deps += [ "${chip_root}/src/wifipaf:wifipaf" ]
public_deps += [ "${chip_root}/src/wifipaf" ]

# Include wifi-paf to commission the device or not
# This is a feature of Wi-Fi spec that it can be enabled if wifi is enabled
# and the supplicant can support.
chip_device_config_enable_wifipaf = chip_enable_wifi && false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& false means false.

Maybe you can assert that if one is true the other one is as well instead.

@@ -34,6 +34,10 @@ source_set("without-logging") {
"${chip_root}/src/transport",
]

if (chip_device_config_enable_wifipaf == true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (chip_device_config_enable_wifipaf == true) {
if (chip_device_config_enable_wifipaf) {

@@ -289,12 +289,15 @@ struct ConnectivityManager::SEDIntervalsConfig
};

#if CHIP_DEVICE_CONFIG_ENABLE_WIFIPAF
#define NAN_FREQ_LIST_ALL 0xff
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use constexpr uint8_t kNaNFreqListAll (or whatever type or name is apropriate instead) to get type safety as well.

* The max amount of time (in seconds) the chip controller will discovery Wi-Fi PAF
*/
#ifndef CHIP_DEVICE_CONFIG_WIFIPAF_DISCOVERY_TIMEOUT
#define CHIP_DEVICE_CONFIG_WIFIPAF_DISCOVERY_TIMEOUT (15 * 60)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit of measurement suffix to all these constants. for seconds it should probably be _SEC

@@ -369,6 +369,71 @@ class SampleTestEventTriggerHandler : public TestEventTriggerHandler
}
};

#if CHIP_DEVICE_CONFIG_ENABLE_WIFIPAF
void int_array_add_unique(uint16_t ** res, uint16_t a)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment on what this method does and usage examples.

void int_array_add_unique(uint16_t ** res, uint16_t a)
{
size_t reslen, max_size;
uint16_t * n;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this closer to usage instead of at a top. Also give it a better name than n. What does it mean.

TLDR: I cannot tell at a glance what this method is doing and what its logic or variables mean. Please make this readable.

*res = n;
}

static uint16_t WiFiPAFGet_FreqList(char * ArgStrn, uint16_t ** pfreq_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also improve readability on this method to:

  • describe what it does and how (what do the arguments mean, how are they transformed, usage examples
  • rename some variables (what is len for example)?
  • is freq_list needed? we seem to use it just for a get and to later place it in pfreq_list. If needed this should be moved to decrease its scope.
  • Can we somehow make it so that ArgStrn can be const? generally this seems the intent and we use non-const so that strtok works.

args.enable = LinuxDeviceOptions::GetInstance().mWiFiPAF;
args.ExtCmds = LinuxDeviceOptions::GetInstance().mWiFiPAFExtCmds;
args.enable = LinuxDeviceOptions::GetInstance().mWiFiPAF;
args.freq_list_len = WiFiPAFGet_FreqList((char *) LinuxDeviceOptions::GetInstance().mWiFiPAFExtCmds, &args.pfreq_list);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast is suspicious. You should use C++-style casts, and then it is a const_cast and that is a code-smell. Fix up WiFiPAFGet_FreqList to accept const char instead.

DeviceLayer::ConnectivityMgr().SetWiFiPAFAdvertisingEnabled(args);
if ((args.freq_list_len > 0) && (args.freq_list_len != NAN_FREQ_LIST_ALL))
Copy link
Contributor

@andy31415 andy31415 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain this code in a comment? why are we freeing all except the all constant?

Why can't this be automatic (like having the ARGS handle memory managment, not the caller)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants