-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DuplicatedAreas error #35126
Remove DuplicatedAreas error #35126
Conversation
Review changes with SemanticDiff. Analyzed 2 of 12 files. Overall, the semantic diff is 61% smaller than the GitHub diff.
|
PR #35126: Size comparison from 8b97b28 to 50da0c2 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, assuming the text noted at https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10254#discussion_r1725535472 doesn't actually say what it means to say.
PR #35126: Size comparison from 8b97b28 to 8757886 Increases above 0.2%:
Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
* Removed the DuplicatedAreas error from the XML * Generated code after XML update. * The service are server ignores any duplicate values before calling the delegate. Example was updated accodingly. * Updated test SEAR-1.3 following changes to the duplicated areas error. * Restyled by clang-format * Made select areas const. --------- Co-authored-by: Restyled.io <[email protected]>
Fixes #35014.
This PR
DuplicateAreas
error form theSelectAreasStatus
enum in the XML.HandleSelectAreasCmd