-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing occupancy event #35220
Merged
Merged
Add missing occupancy event #35220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tcarmelveilleux
commented
Aug 27, 2024
- Add missing occupancy event (fixes demand for event change state of occupancy cluster #33528)
- Update occupancy sensor device type revision to 4 (issue https://github.com/CHIP-Specifications/chip-test-plans/pull/4570)
- Update description of occupancy sensor cluster ([1.3] Inconsistent Description for Occupancy Sensing cluster #34278)
Review changes with SemanticDiff. Analyzed 3 of 49 files. Overall, the semantic diff is 4% smaller than the GitHub diff. File Information
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin and
jepenven-silabs
August 27, 2024 13:29
pullapprove
bot
requested review from
robszewczyk,
turon,
saurabhst,
vivien-apple,
selissia,
wiba-nordic,
sharadb-amazon,
woody-apple,
tecimovic,
younghak-hwang,
tima-q,
yufengwangca,
tobiasgraf and
yunhanw-google
August 27, 2024 13:29
PR #35220: Size comparison from d185778 to 35349df Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Aug 27, 2024
tehampson
approved these changes
Aug 27, 2024
PeterC1965
pushed a commit
to PeterC1965/connectedhomeip
that referenced
this pull request
Aug 28, 2024
* XML: Add OccupancyChanged event * Regen zap
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* XML: Add OccupancyChanged event * Regen zap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.