Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing occupancy event #35220

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Add missing occupancy event #35220

merged 2 commits into from
Aug 27, 2024

Conversation

tcarmelveilleux
Copy link
Contributor

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 27, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 3 of 49 files.

Overall, the semantic diff is 4% smaller than the GitHub diff.

File Information
Filename Status
❔ zzz_generated/darwin-framework-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/Commands.h Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.cpp Unsupported file format
❔ zzz_generated/chip-tool/zap-generated/cluster/logging/DataModelLogger.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.cpp Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Unsupported file format
❔ zzz_generated/app-common/app-common/zap-generated/ids/Events.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterConstants.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusterNames.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRClusters.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTREventTLVValueDecoder.mm Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.h Unsupported file format
❔ src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.mm Unsupported file format
✔️ src/controller/python/chip/clusters/Objects.py Analyzed
❔ src/controller/java/zap-generated/CHIPEventTLVValueDecoder.cpp Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/files.gni Unsupported file format
❔ src/controller/java/generated/java/matter/controller/cluster/eventstructs/OccupancySensingClusterOccupancyChangedEvent.kt Unsupported file format
✔️ src/controller/java/generated/java/chip/devicecontroller/ChipEventStructs.java Analyzed
✔️ src/controller/java/generated/java/chip/devicecontroller/ClusterIDMapping.java 79.41% smaller
❔ src/controller/java/generated/java/chip/devicecontroller/cluster/files.gni Unsupported file format
❔ src/controller/java/generated/java/chip/devicecontroller/cluster/eventstructs/OccupancySensingClusterOccupancyChangedEvent.kt Unsupported file format
❔ src/controller/data_model/controller-clusters.matter Unsupported file format
❔ src/app/zap-templates/zcl/data-model/chip/occupancy-sensing-cluster.xml Unsupported file format
❔ examples/pump-app/silabs/data_model/pump-thread-app.matter Unsupported file format
❔ examples/pump-app/silabs/data_model/pump-wifi-app.matter Unsupported file format
❔ examples/pump-app/pump-common/pump-app.matter Unsupported file format
❔ examples/placeholder/linux/apps/app2/config.matter Unsupported file format
❔ examples/placeholder/linux/apps/app2/config.zap Unsupported file format
❔ examples/placeholder/linux/apps/app1/config.matter Unsupported file format
❔ examples/placeholder/linux/apps/app1/config.zap Unsupported file format
❔ examples/lighting-app/lighting-common/lighting-app.matter Unsupported file format
❔ examples/lighting-app/lighting-common/lighting-app.zap Unsupported file format
❔ examples/light-switch-app/qpg/zap/switch.zap Unsupported file format
❔ examples/light-switch-app/light-switch-common/light-switch-app.zap Unsupported file format
❔ examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter Unsupported file format
❔ examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.zap Unsupported file format
❔ examples/chef/sample_app_util/test_files/sample_zap_file.zap Unsupported file format
❔ examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter Unsupported file format
❔ examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter Unsupported file format
❔ examples/chef/devices/rootnode_dimmablepluginunit_f8a9a0b9d4.matter Unsupported file format
❔ examples/chef/devices/rootnode_genericswitch_2dfff6e516.zap Unsupported file format
❔ examples/chef/devices/rootnode_genericswitch_9866e35d0b.zap Unsupported file format
❔ examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter Unsupported file format
❔ examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.zap Unsupported file format
❔ examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter Unsupported file format
❔ examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter Unsupported file format
❔ examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap Unsupported file format
❔ examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

PR #35220: Size comparison from d185778 to 35349df

Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section d185778 35349df change % change
bl602 lighting-app bl602 FLASH 1278596 1278596 0 0.0
RAM 95880 95880 0 0.0
bl602+mfd FLASH 1292706 1292706 0 0.0
RAM 96024 96024 0 0.0
bl602+rpc FLASH 1317560 1317560 0 0.0
RAM 104304 104304 0 0.0
bl702 lighting-app bl702 FLASH 944224 944224 0 0.0
RAM 15209 15209 0 0.0
bl702+mfd FLASH 946624 946624 0 0.0
RAM 15353 15353 0 0.0
bl702+rpc FLASH 1039536 1039536 0 0.0
RAM 24221 24221 0 0.0
bl706-eth FLASH 647296 647296 0 0.0
RAM 25305 25305 0 0.0
bl706-wifi FLASH 894668 894668 0 0.0
RAM 14525 14525 0 0.0
bl702l lighting-app bl702l FLASH 960884 960884 0 0.0
RAM 16868 16868 0 0.0
bl702l+mfd FLASH 963506 963506 0 0.0
RAM 17012 17012 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 672457 672457 0 0.0
RAM 78300 78300 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 692309 692309 0 0.0
RAM 80932 80932 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 692309 692309 0 0.0
RAM 80932 80932 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 649253 649253 0 0.0
RAM 73368 73368 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 610969 610969 0 0.0
RAM 71292 71292 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 630597 630597 0 0.0
RAM 73844 73844 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 630597 630597 0 0.0
RAM 73844 73844 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 629001 629001 0 0.0
RAM 74308 74308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 648717 648717 0 0.0
RAM 76860 76860 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 648717 648717 0 0.0
RAM 76860 76860 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 602797 602797 0 0.0
RAM 68348 68348 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 622649 622649 0 0.0
RAM 70980 70980 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 622649 622649 0 0.0
RAM 70980 70980 0 0.0
efr32 lighting-app BRD4187C FLASH 930532 930532 0 0.0
RAM 135096 135096 0 0.0
lock-app BRD4338a FLASH 740604 740596 -8 -0.0
RAM 208492 208492 0 0.0
window-app BRD4187C FLASH 1015656 1015656 0 0.0
RAM 127036 127036 0 0.0
esp32 all-clusters-app c3devkit DRAM 94200 94200 0 0.0
FLASH 1533674 1533674 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115136 115136 0 0.0
FLASH 1543638 1543634 -4 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4624 4624 0 0.0
FLASH 2758323 2758323 0 0.0
RAM 128472 128472 0 0.0
all-clusters-app debug unknown 5408 5408 0 0.0
FLASH 6045250 6045250 0 0.0
RAM 509992 510056 64 0.0
all-clusters-minimal-app debug unknown 5304 5304 0 0.0
FLASH 5381162 5381162 0 0.0
RAM 240200 240200 0 0.0
bridge-app debug unknown 5288 5288 0 0.0
FLASH 4729896 4729896 0 0.0
RAM 216952 216952 0 0.0
chip-tool debug unknown 5832 5832 0 0.0
FLASH 12647116 12648884 1768 0.0
RAM 558290 558354 64 0.0
chip-tool-ipv6only arm64 unknown 20352 20352 0 0.0
FLASH 11319484 11320668 1184 0.0
RAM 608336 608440 104 0.0
fabric-admin debug unknown 5664 5664 0 0.0
FLASH 10926467 10926671 204 0.0
RAM 556490 556554 64 0.0
fabric-bridge-app debug unknown 4520 4520 0 0.0
FLASH 4552096 4552096 0 0.0
RAM 203680 203680 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5665937 5665937 0 0.0
RAM 228008 228008 0 0.0
lock-app debug unknown 5224 5224 0 0.0
FLASH 4785242 4785242 0 0.0
RAM 203736 203736 0 0.0
ota-provider-app debug unknown 4600 4600 0 0.0
FLASH 4424716 4424716 0 0.0
RAM 197720 197720 0 0.0
ota-requestor-app debug unknown 4536 4536 0 0.0
FLASH 4563334 4563334 0 0.0
RAM 202256 202256 0 0.0
shell debug unknown 4176 4176 0 0.0
FLASH 3083581 3083581 0 0.0
RAM 159000 159000 0 0.0
thermostat-no-ble arm64 unknown 9296 9296 0 0.0
FLASH 4321068 4321068 0 0.0
RAM 241848 241848 0 0.0
tv-app debug unknown 5504 5504 0 0.0
FLASH 6009765 6009765 0 0.0
RAM 583192 583256 64 0.0
tv-casting-app debug unknown 5168 5168 0 0.0
FLASH 10851901 10853629 1728 0.0
RAM 645720 645784 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 910212 910212 0 0.0
RAM 142219 142219 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 882200 882200 0 0.0
RAM 140358 140358 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 841268 841268 0 0.0
RAM 141038 141038 0 0.0
nxp contact k32w0+release FLASH 577580 577580 0 0.0
RAM 70444 70444 0 0.0
k32w1+release FLASH 590208 590208 0 0.0
RAM 62488 62488 0 0.0
light k32w0+release FLASH 613008 613008 0 0.0
RAM 69916 69916 0 0.0
k32w1+release FLASH 674880 674880 0 0.0
RAM 71472 71472 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1641036 1641036 0 0.0
RAM 210920 210920 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1544732 1544732 0 0.0
RAM 207632 207632 0 0.0
light cy8ckit_062s2_43012 FLASH 1464364 1464364 0 0.0
RAM 200728 200728 0 0.0
lock cy8ckit_062s2_43012 FLASH 1463412 1463412 0 0.0
RAM 225064 225064 0 0.0
qpg lighting-app qpg6105+debug FLASH 656068 656068 0 0.0
RAM 105128 105128 0 0.0
lock-app qpg6105+debug FLASH 613992 613992 0 0.0
RAM 99612 99612 0 0.0
stm32 light STM32WB5MM-DK FLASH 478424 478424 0 0.0
RAM 144716 144716 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620280 620280 0 0.0
RAM 50932 50932 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 682044 682044 0 0.0
RAM 149552 149552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 774286 774286 0 0.0
RAM 110712 110712 0 0.0
bridge-app tlsr9258a FLASH 679010 679010 0 0.0
RAM 91588 91588 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621872 621872 0 0.0
RAM 50972 50972 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707880 707880 0 0.0
RAM 74312 74312 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 620712 620712 0 0.0
RAM 145532 145532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 806844 806844 0 0.0
RAM 99456 99456 0 0.0
lock-app-dfu tlsr9528a FLASH 654854 654854 0 0.0
RAM 67008 67008 0 0.0
ota-requestor-app tlsr9258a FLASH 697138 697138 0 0.0
RAM 91272 91272 0 0.0
pump-app-usb tlsr9518adk80d FLASH 631318 631318 0 0.0
RAM 55752 55752 0 0.0
pump-controller-app tlsr9518adk80d FLASH 608828 608828 0 0.0
RAM 52996 52996 0 0.0
shell tlsr9518adk80d FLASH 466816 466816 0 0.0
RAM 68660 68660 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628662 628662 0 0.0
RAM 52692 52692 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652810 652810 0 0.0
RAM 56632 56632 0 0.0
thermostat tlsr9518adk80d FLASH 635128 635128 0 0.0
RAM 53400 53400 0 0.0
window-covering tlsr9118bdk40d FLASH 522814 522814 0 0.0
RAM 98532 98532 0 0.0
tizen all-clusters-app arm unknown 4832 4832 0 0.0
FLASH 1706760 1706760 0 0.0
RAM 89340 89340 0 0.0
chip-tool-ubsan arm unknown 10272 10272 0 0.0
FLASH 17492462 17494190 1728 0.0
RAM 7599476 7600188 712 0.0

@mergify mergify bot merged commit 32c961f into project-chip:master Aug 27, 2024
70 checks passed
PeterC1965 pushed a commit to PeterC1965/connectedhomeip that referenced this pull request Aug 28, 2024
@tcarmelveilleux @PeterC1965
Add missing occupancy event (project-chip#35220)
c6977dd 
* XML: Add OccupancyChanged event

* Regen zap
@tcarmelveilleux tcarmelveilleux mentioned this pull request Aug 30, 2024
Closed
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Sep 10, 2024
@tcarmelveilleux @shgutte
Add missing occupancy event (project-chip#35220)
dc70497 
* XML: Add OccupancyChanged event

* Regen zap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehampson tehampson tehampson approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
app controller darwin examples review - approved
Projects
[Device Type] Ambient Sensing
Status: Done
[Feature] Occupancy Sensing updates for Ambient Sensing
Status: Done
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

demand for event change state of occupancy cluster
3 participants
@tcarmelveilleux @tehampson @jmartinez-silabs