-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Matter.framework] Clear all device controller delegates on controlle… #35935
Merged
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterFramework_ClearDeviceControllerDelegates
Oct 9, 2024
Merged
[Matter.framework] Clear all device controller delegates on controlle… #35935
mergify
merged 1 commit into
project-chip:master
from
vivien-apple:MatterFramework_ClearDeviceControllerDelegates
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review changes with SemanticDiff. |
PR #35935: Size comparison from bcc1f1b to 738b4f7 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
Oct 7, 2024
woody-apple
reviewed
Oct 7, 2024
PR #35935: Size comparison from 1c2ad2e to f683202 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
vivien-apple
force-pushed
the
MatterFramework_ClearDeviceControllerDelegates
branch
from
October 8, 2024 11:05
f683202
to
d960b87
Compare
PR #35935: Size comparison from 1dadbe4 to d960b87 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 8, 2024
vivien-apple
force-pushed
the
MatterFramework_ClearDeviceControllerDelegates
branch
from
October 9, 2024 07:46
d960b87
to
57de6c7
Compare
PR #35935: Size comparison from a629204 to 57de6c7 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Fast-tracking platform-specific fix with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r shutdown
Problem
When
darwin-framework-tool
sets the pairing delegate in [1], it leads to a memory leak. To resolve this, we could either clear the delegate indarwin-framework-tool
or clear all delegates during controller shutdown. I chose the latter approach.[1]
connectedhomeip/examples/darwin-framework-tool/commands/pairing/PairingCommandBridge.mm
Line 87 in bcc1f1b