Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of controllerNodeID on non-concrete controllers. #35946

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix handling of controllerNodeID on non-concrete controllers. #35946

merged 1 commit into from
Oct 7, 2024

Commits on Oct 7, 2024

  1. Fix handling of controllerNodeID on non-concrete controllers. 

    There isn't actually a _cppCommissioner on the base controller, so that
implementation made no sense.  In practice, the XPC and concrete controller just
have different implementations here, and the base should not try to implement
anything.

Also fixes the concrete implementation to avoid a sync dispatch by caching the
value (which should be immutable) during startup and removes the unnecessary
controllerNodeId override from the concrete controller: the base class handles
that backwards compat shim already.
    @bzbarsky-apple
    bzbarsky-apple committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b5bffe5 View commit details
    Browse the repository at this point in the history