Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up asyncGetCommissionerOnMatterQueue on MTRDeviceController. #35947

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Clean up asyncGetCommissionerOnMatterQueue on MTRDeviceController. #35947

merged 1 commit into from
Oct 7, 2024

Conversation

bzbarsky-apple
Copy link
Contributor

MTROperationalCredentialsDelegate always works with a concrete controller. Make that explicit.

At that point, asyncGetCommissionerOnMatterQueue can only get called on an MTRDeviceController from and MTRBaseDevice that was created for an XPC controller. Having that just fail out is perfectly reasonable.

@bzbarsky-apple
Clean up asyncGetCommissionerOnMatterQueue on MTRDeviceController.
cd6f361 
MTROperationalCredentialsDelegate always works with a concrete controller.  Make
that explicit.

At that point, asyncGetCommissionerOnMatterQueue can only get called on an
MTRDeviceController from and MTRBaseDevice that was created for an XPC
controller.  Having that just fail out is perfectly reasonable.
@bzbarsky-apple bzbarsky-apple requested a review from a team as a code owner October 7, 2024 17:36
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

PR #35947: Size comparison from 1c2ad2e to cd6f361

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 1c2ad2e cd6f361 change % change
bl602 lighting-app bl602 FLASH 1280566 1280566 0 0.0
RAM 95808 95808 0 0.0
bl602+mfd FLASH 1308614 1308614 0 0.0
RAM 95464 95464 0 0.0
bl602+rpc FLASH 1335234 1335234 0 0.0
RAM 103784 103784 0 0.0
bl702 lighting-app bl702 FLASH 944954 944954 0 0.0
RAM 15105 15105 0 0.0
bl702+mfd FLASH 957408 957408 0 0.0
RAM 14769 14769 0 0.0
bl702+rpc FLASH 1051112 1051112 0 0.0
RAM 23661 23661 0 0.0
bl706-eth FLASH 658086 658086 0 0.0
RAM 24745 24745 0 0.0
bl706-wifi FLASH 824882 824882 0 0.0
RAM 13965 13965 0 0.0
bl702l lighting-app bl702l FLASH 961890 961890 0 0.0
RAM 16804 16804 0 0.0
bl702l+mfd FLASH 974652 974652 0 0.0
RAM 16468 16468 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829292 829292 0 0.0
RAM 123292 123292 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814616 814616 0 0.0
RAM 125172 125172 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761164 761164 0 0.0
RAM 113664 113664 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745400 745400 0 0.0
RAM 113856 113856 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 616898 616898 0 0.0
RAM 205396 205396 0 0.0
lock CC3235SF_LAUNCHXL FLASH 656986 656986 0 0.0
RAM 205548 205548 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678245 678245 0 0.0
RAM 78508 78508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698097 698097 0 0.0
RAM 81140 81140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698097 698097 0 0.0
RAM 81140 81140 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655033 655033 0 0.0
RAM 73576 73576 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614589 614589 0 0.0
RAM 71468 71468 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634217 634217 0 0.0
RAM 74020 74020 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634217 634217 0 0.0
RAM 74020 74020 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 633901 633901 0 0.0
RAM 74516 74516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653617 653617 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653617 653617 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609205 609205 0 0.0
RAM 68604 68604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629065 629065 0 0.0
RAM 71236 71236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629065 629065 0 0.0
RAM 71236 71236 0 0.0
efr32 lighting-app BRD4187C FLASH 933780 933780 0 0.0
RAM 135876 135876 0 0.0
lock-app BRD2605a FLASH 740184 740184 0 0.0
RAM 230240 230240 0 0.0
BRD4338a FLASH 740832 740832 0 0.0
RAM 230272 230272 0 0.0
window-app BRD4187C FLASH 1017192 1017184 -8 -0.0
RAM 127804 127804 0 0.0
esp32 all-clusters-app c3devkit DRAM 94080 94080 0 0.0
FLASH 1538394 1538394 0 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 115032 115032 0 0.0
FLASH 1548846 1548846 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2779561 2779561 0 0.0
RAM 129488 129488 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6083538 6083538 0 0.0
RAM 510560 510560 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5416790 5416790 0 0.0
RAM 241200 241200 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4750210 4750210 0 0.0
RAM 218384 218384 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12652932 12652932 0 0.0
RAM 560658 560658 0 0.0
chip-tool-ipv6only arm64 unknown 20672 20672 0 0.0
FLASH 11291488 11291488 0 0.0
RAM 610976 610976 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11000757 11000757 0 0.0
RAM 560314 560314 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4573176 4573176 0 0.0
RAM 205048 205048 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5690017 5690017 0 0.0
RAM 228456 228456 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4799806 4799806 0 0.0
RAM 204472 204472 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4429194 4429194 0 0.0
RAM 198192 198192 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4568010 4568010 0 0.0
RAM 202760 202760 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3109597 3109597 0 0.0
RAM 159280 159280 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4317920 4317920 0 0.0
RAM 242888 242888 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6027669 6027669 0 0.0
RAM 584096 584096 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10849469 10849469 0 0.0
RAM 648944 648944 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914176 914176 0 0.0
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884960 884960 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847596 847596 0 0.0
RAM 141093 141093 0 0.0
nxp contact k32w0+release FLASH 581944 581944 0 0.0
RAM 70784 70784 0 0.0
k32w1+release FLASH 596656 596656 0 0.0
RAM 63008 63008 0 0.0
mcxw71+release FLASH 596416 596416 0 0.0
RAM 63008 63008 0 0.0
light k32w0+release FLASH 618532 618532 0 0.0
RAM 70256 70256 0 0.0
k32w1+release FLASH 682640 682640 0 0.0
RAM 48648 48648 0 0.0
mcxw71+release FLASH 682640 682640 0 0.0
RAM 48648 48648 0 0.0
lock k32w1+release FLASH 705016 705016 0 0.0
RAM 67148 67148 0 0.0
mcxw71+release FLASH 705024 705024 0 0.0
RAM 67148 67148 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646060 1646060 0 0.0
RAM 210888 210888 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552116 1552116 0 0.0
RAM 207688 207688 0 0.0
light cy8ckit_062s2_43012 FLASH 1467588 1467588 0 0.0
RAM 200688 200688 0 0.0
lock cy8ckit_062s2_43012 FLASH 1464660 1464660 0 0.0
RAM 225048 225048 0 0.0
qpg lighting-app qpg6105+debug FLASH 660280 660280 0 0.0
RAM 105236 105236 0 0.0
lock-app qpg6105+debug FLASH 618292 618292 0 0.0
RAM 99704 99704 0 0.0
stm32 light STM32WB5MM-DK FLASH 481576 481576 0 0.0
RAM 144684 144684 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620692 620692 0 0.0
RAM 50488 50488 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687888 687888 0 0.0
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780880 780880 0 0.0
RAM 110280 110280 0 0.0
bridge-app tlsr9258a FLASH 680790 680790 0 0.0
RAM 91144 91144 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620456 620456 0 0.0
RAM 50440 50440 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708396 708396 0 0.0
RAM 73780 73780 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625394 625394 0 0.0
RAM 144308 144308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811154 811154 0 0.0
RAM 98940 98940 0 0.0
lock-app-dfu tlsr9528a FLASH 656362 656362 0 0.0
RAM 66500 66500 0 0.0
ota-requestor-app tlsr9258a FLASH 696766 696766 0 0.0
RAM 90736 90736 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634088 634088 0 0.0
RAM 55316 55316 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611278 611278 0 0.0
RAM 52560 52560 0 0.0
shell tlsr9518adk80d FLASH 467872 467872 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627586 627586 0 0.0
RAM 52160 52160 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653414 653414 0 0.0
RAM 56108 56108 0 0.0
thermostat tlsr9518adk80d FLASH 638010 638010 0 0.0
RAM 52952 52952 0 0.0
window-covering tlsr9118bdk40d FLASH 524152 524152 0 0.0
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4904 4904 0 0.0
FLASH 1725768 1725768 0 0.0
RAM 89076 89076 0 0.0
chip-tool-ubsan arm unknown 10424 10424 0 0.0
FLASH 17509698 17509698 0 0.0
RAM 7626972 7626972 0 0.0

@mergify mergify bot merged commit 7fd3d59 into project-chip:master Oct 7, 2024
69 checks passed
@bzbarsky-apple bzbarsky-apple deleted the asyncGetCommissionerOnMatterQueue-cleanup branch October 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @woody-apple @jtung-apple