[Darwin] Internal state plumbing for the _XPC classes #35962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
jtung-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
from
bfb416b
to
8234e8c
Compare
jtung-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
from
a5aab2a
to
97926a2
Compare
|
PR #35962: Size comparison from 150db87 to 97926a2 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35962: Size comparison from 150db87 to 77b4313 Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
previously requested changes
Oct 19, 2024
|
PR #35962: Size comparison from 813c245 to 61da89f Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35962: Size comparison from 813c245 to a6f8bf9 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
2 times, most recently
from
4d6f1d3
to
1501df0
Compare
woody-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
from
1501df0
to
f85d1dc
Compare
woody-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
from
b2f72d1
to
21bed7e
Compare
woody-apple
reviewed
Oct 28, 2024
|
PR #35962: Size comparison from bcdddaa to 2a35463 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
force-pushed
the
jtung/darwin-xpc-state-plumbing
branch
from
58c9c06
to
7f32eb8
Compare
woody-apple
approved these changes
Oct 29, 2024
|
PR #35962: Size comparison from c18a6de to 07deb34 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #35962: Size comparison from c18a6de to fb4cf85 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Oct 29, 2024
|
PR #35962: Size comparison from c18a6de to 8cb98cf Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MTRDevice_XPC and MTRDeviceController_XPC classes have properties / internal state that is queried through XPC every time. This PR aims to plumb initial retrieval and update of this info, to avoid an XPC trip every time.