-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python_lib build&test out of darwin build steps #35980
Conversation
After project-chip#34892 this build is a noop so we do not benefit from running the build a 2nd time. This should save some CI time.
Review changes with SemanticDiff. |
PR #35980: Size comparison from 7fcc60f to 748b62f Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <[email protected]>
PR #35980: Size comparison from 7fcc60f to de9a080 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
BUILD_TYPE=$BUILD_TYPE scripts/tests/gn_tests.sh | ||
done | ||
- name: Ensure codegen is done for sanitize | ||
# We want to build various standalone example apps similar to what examples-linux-standalone.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The open paren here to match the close paren on the next line went away for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #36010
After #34892 this build is a noop so we do not benefit from running the build a 2nd time.
This should save some CI time (this build and test currently runs in 1.5 hours ... if we actually do 2x the work like it seems we do, this may save 45 minutes of CI)