[IM] Handle internal fatal error in BufferReadCallback #36187
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
yunhanw-google
force-pushed
the
feature/handle_error_BufferReaderCallback
branch
from
f615c29
to
a75bf72
Compare
|
PR #36187: Size comparison from 9ee0499 to 2167712 Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 23, 2024
yunhanw-google
force-pushed
the
feature/handle_error_BufferReaderCallback
branch
2 times, most recently
from
bb45a1c
to
7a20bd8
Compare
|
PR #36187: Size comparison from fef41bd to 7a20bd8 Full report (3 builds for cc32xx, stm32)
|
yunhanw-google
force-pushed
the
feature/handle_error_BufferReaderCallback
branch
from
7a20bd8
to
44484ae
Compare
|
PR #36187: Size comparison from fef41bd to 44484ae Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive #30965
Issue: If onError has been called from BufferedReadCallback when processing multiple attrbitues, potentially onError or onAttribute or onEvent could be called again from ReadClient, as a result, the behavior in application could be unexpected, crash is possible. note: the errors in BufferredReadCallback are treated as fatal ones.
Solution: In order to resolve the above issue, we introduce a new callback, CheckInternalError
We could set a flag in the buffered read callback that returns error for the next call from ReadClient, then we can call CheckInternalError after we handle onAttribute, and lead to a Error for ReadClient::Close and mpCallback.OnError, which also imply we can remove onError call inside BufferedReadCallback, and make sure onError should be called only with close path from readClient.