Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FanControl: modify percentSetting/percentSpeedSetting return value in case NULL is written (match spec) #36242

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

FanControl: modify percentSetting/percentSpeedSetting return value in case NULL is written (match spec) #36242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d509269
Modified return value as per spec
arun-silabs Oct 25, 2024
feb6883
Modified return value for speedSetting attribute
arun-silabs Oct 25, 2024
d2220b3
Merge branch 'master' into bugfix/fix_return_value_for_fan
arun-silabs Oct 25, 2024
7ff9f2e
Updated test suite with return value.
arun-silabs Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/clusters/fan-control-server/fan-control-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute
}
else
{
res = Status::WriteIgnored;
res = Status::InvalidInState;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We apparently have no test coverage, since nothing started failing.

Please add a basic YAML test that exercises this.

}
}
else
Expand Down Expand Up @@ -234,7 +234,7 @@ MatterFanControlClusterServerPreAttributeChangedCallback(const ConcreteAttribute
}
else
{
res = Status::WriteIgnored;
res = Status::InvalidInState;
}
}
else
Expand Down
4 changes: 4 additions & 0 deletions src/app/tests/suites/TestFanControl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ tests:
attribute: "PercentSetting"
arguments:
value: null
response:
error: INVALID_IN_STATE

- label: "Read back percent setting"
command: "readAttribute"
Expand Down Expand Up @@ -105,6 +107,8 @@ tests:
attribute: "SpeedSetting"
arguments:
value: null
response:
error: INVALID_IN_STATE

- label: "Read back speed setting"
command: "readAttribute"
Expand Down
Loading