[Tizen] Add code coverage for tests on QEMU #36245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 3 of 9 files. Overall, the semantic diff is 4% smaller than the GitHub diff.
|
|
PR #36245: Size comparison from f1457a2 to 43f4425 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Oct 25, 2024
arkq
added
the
changing-submodules-on-purpose
|
PR #36245: Size comparison from f1457a2 to d605b12 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36245: Size comparison from f1457a2 to ab0a679 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Oct 28, 2024
scripts/build/builders/tizen.py
Outdated
| gcov = os.path.join(os.environ['TIZEN_SDK_TOOLCHAIN'], 'bin/arm-linux-gnueabi-gcov') | ||
|
|
||
| self._Execute(['lcov', '--gcov-tool', gcov, '--initial', '--ignore-errors', 'unused', '--capture', '--directory', os.path.join(self.output_dir, 'obj'), | ||
| '--exclude', '**/src/controller/*', |
There was a problem hiding this comment.
this should probably be in some separate list as it is repeated and very independent from the other arguments.
There was a problem hiding this comment.
It looks like we want some shared gcov arguments and then only have the diffs inside build and post build.
There was a problem hiding this comment.
Is it okay like this?
arkq
reviewed
Oct 29, 2024
| if self.app == TizenApp.TESTS and self.use_coverage: | ||
|
|
||
| self._Execute(self.lcov_args() + ['--output-file', os.path.join(self.coverage_dir, | ||
| 'lcov_test.info')], title="Initial coverage baseline") |
There was a problem hiding this comment.
Suggested change
| 'lcov_test.info')], title="Initial coverage baseline") | |
| 'lcov_test.info')], title="Update coverage") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Add code coverage for Tizen tests on QEMU in a similar way other targets do this:
-coveragetarget suffix,LCOVtool and generating HTML as final output.This feature uses previously added (#35786) 9P-based file sharing to export
.gcdafiles from guest to host and because of that slight path remapping was needed:As for the integrations tests:
lightning appwas omitted since it is being sandboxed and thus require extra effort.Testing
Successfully generated HTML file containing the combined coverage for all* tests.