Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CHIP-specific backends for pigweed assert and logs #36297

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

andy31415
Copy link
Contributor

Without this, we funnel into pigweed basic logging (which uses stdout and does not hook into general chip logging) and asserts are not using chip assert macros.

This would allow us to eventually use more of pigweed generic modules (e.g. bytes, base64, functions) without losing matter module integration.

Copy link

semanticdiff-com bot commented Oct 30, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  examples/common/pigweed/rpc_console/py/chip_rpc/console.py  1% smaller
  .gn Unsupported file format
  config/bouffalolab/common/lib/pw_rpc/pw_rpc.gni Unsupported file format
  config/efr32/lib/pw_rpc/pw_rpc.gni Unsupported file format
  config/mbed/chip-gn/lib/pw_rpc/pw_rpc.gni Unsupported file format
  config/nxp/lib/pw_rpc/pw_rpc.gni Unsupported file format
  config/qpg/lib/pw_rpc/pw_rpc.gni Unsupported file format
  examples/all-clusters-app/linux/with_pw_rpc.gni Unsupported file format
  examples/android/CHIPTest/args.gni Unsupported file format
  examples/chef/linux/with_pw_rpc.gni Unsupported file format
  examples/common/pigweed/RpcService.cpp Unsupported file format
  examples/common/pigweed/system_rpc_server.cc Unsupported file format
  examples/fabric-admin/with_pw_rpc.gni Unsupported file format
  examples/fabric-bridge-app/linux/with_pw_rpc.gni Unsupported file format
  examples/light-switch-app/genio/args.gni Unsupported file format
  examples/light-switch-app/genio/build_for_wifi_args.gni Unsupported file format
  examples/light-switch-app/qpg/args.gni Unsupported file format
  examples/lighting-app-data-mode-no-unique-id/linux/with_pw_rpc.gni Unsupported file format
  examples/lighting-app/bouffalolab/bl602/args.gni Unsupported file format
  examples/lighting-app/bouffalolab/bl702/args.gni Unsupported file format
  examples/lighting-app/bouffalolab/bl702l/args.gni Unsupported file format
  examples/lighting-app/genio/args.gni Unsupported file format
  examples/lighting-app/genio/build_for_wifi_args.gni Unsupported file format
  examples/lighting-app/linux/with_pw_rpc.gni Unsupported file format
  examples/lighting-app/qpg/args.gni Unsupported file format
  examples/lock-app/genio/args.gni Unsupported file format
  examples/lock-app/genio/build_for_wifi_args.gni Unsupported file format
  examples/lock-app/qpg/args.gni Unsupported file format
  examples/ota-requestor-app/genio/args.gni Unsupported file format
  examples/ota-requestor-app/genio/build_for_wifi_args.gni Unsupported file format
  examples/platform/linux/system_rpc_server.cc Unsupported file format
  examples/shell/genio/args.gni Unsupported file format
  examples/shell/qpg/args.gni Unsupported file format
  examples/thermostat/genio/args.gni Unsupported file format
  examples/thermostat/genio/build_for_wifi_args.gni Unsupported file format
  examples/thermostat/qpg/args.gni Unsupported file format
  src/app/tests/BUILD.gn Unsupported file format
  src/backends/assert/BUILD.gn Unsupported file format
  src/backends/assert/handler.cpp Unsupported file format
  src/backends/assert/public/pw_assert_matter/handler.h Unsupported file format
  src/backends/assert/public_overrides/pw_assert_backend/check_backend.h Unsupported file format
  src/backends/log/BUILD.gn Unsupported file format
  src/backends/log/public/pw_log_matter/log_matter.h Unsupported file format
  src/backends/log/public_overrides/pw_log_backend/log_backend.h Unsupported file format
  src/lib/support/pw_log_chip/BUILD.gn Unsupported file format
  src/lib/support/pw_log_chip/public/pw_log_chip/log_chip.h Unsupported file format
  src/platform/Linux/Logging.cpp Unsupported file format
  src/platform/NuttX/Logging.cpp Unsupported file format
  src/test_driver/efr32/args.gni Unsupported file format

…ad of previous built-in/basic ones. Remove old log backend
Copy link

PR #36297: Size comparison from 7df7676 to 4935a35

Full report (3 builds for cc32xx, stm32)
platform target config section 7df7676 4935a35 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 625798 625798 0 0.0
RAM 206132 206132 0 0.0
lock CC3235SF_LAUNCHXL FLASH 665774 665774 0 0.0
RAM 206284 206284 0 0.0
stm32 light STM32WB5MM-DK FLASH 481392 481392 0 0.0
RAM 144844 144844 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants