Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with latest log version #199

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

ivmarkov
Copy link
Contributor

@ivmarkov ivmarkov commented Jul 9, 2024

The reason why the CI of tlv-tool started failing lately is because there is a new check in latest log which checks if there are multiple, incompatible log-max-levels which are specified as features.

And we do have incompatibility:

  • In rs-matter:
log = { version = "0.4", features = ["max_level_debug", "release_max_level_debug"] }

(This is since forever, i.e. since before I was around.)

  • In tlv-tool:
log = {version = "0.4.14", features = ["max_level_trace", "release_max_level_warn"]}

This PR simply removes the custom levels from tlv-tool and tlv-tool will use the ones from rs-matter (which might have been the case anyway before - silently).

Open to other suggestions.

@ivmarkov ivmarkov requested a review from kedars July 9, 2024 07:56
@kedars kedars merged commit 40e3820 into project-chip:main Jul 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants