Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors reported by latest Clippy #204

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

ivmarkov
Copy link
Contributor

@ivmarkov ivmarkov commented Sep 8, 2024

Subject says it all - restore the CI by addressing a few errors reported by latest Clippy.

Copy link

semanticdiff-com bot commented Sep 8, 2024

Review changes with SemanticDiff.

Analyzed 2 of 3 files.

Overall, the semantic diff is 74% smaller than the GitHub diff.

Filename Status
✔️ rs-matter/src/mdns/proto.rs Analyzed
✔️ rs-matter/src/cert/mod.rs 76.59% smaller
.github/workflows/ci-tlv-tool.yml Unsupported file format

@ivmarkov ivmarkov requested review from andy31415 and kedars September 8, 2024 08:59
@ivmarkov ivmarkov closed this Sep 14, 2024
@ivmarkov ivmarkov deleted the fix-clippy-errs branch September 14, 2024 15:04
@ivmarkov ivmarkov restored the fix-clippy-errs branch September 14, 2024 16:34
@ivmarkov ivmarkov reopened this Sep 14, 2024
@ivmarkov
Copy link
Contributor Author

@kedars we need this merged or else the other PRs CI would also fail.

@kedars kedars merged commit 2dc8cff into project-chip:main Sep 14, 2024
12 checks passed
@ivmarkov ivmarkov deleted the fix-clippy-errs branch November 28, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants