Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow endpoints with multiple device types #205

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

koalatux
Copy link
Contributor

Bridged devices need to implement multiple device types on an endpoint. Changing the device_types field in the Endpoint struct to a slice will allow that.

Copy link

semanticdiff-com bot commented Sep 13, 2024

Review changes with SemanticDiff.

Analyzed 7 of 7 files.

Overall, the semantic diff is 46% smaller than the GitHub diff.

Filename Status
✔️ rs-matter/tests/common/im_engine.rs Analyzed
✔️ rs-matter/tests/common/e2e/im/handler.rs Analyzed
✔️ rs-matter/src/data_model/root_endpoint.rs 50.81% smaller
✔️ rs-matter/src/data_model/system_model/descriptor.rs 75.17% smaller
✔️ rs-matter/src/data_model/objects/endpoint.rs 79.18% smaller
✔️ examples/onoff_light_bt/src/main.rs 51.04% smaller
✔️ examples/onoff_light/src/main.rs 38.38% smaller

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

@ivmarkov
Copy link
Contributor

@koalatux
(Sorry for asking, but I can't seem to resolve the CI errors in this PR by just re-running the jobs - the errors are actually not caused by your PR).
Can you make a dummy commit so that the PR CI gets re-triggered in a clean way?

@ivmarkov
Copy link
Contributor

Thanks - let's wait a few days until #208 gets through. Otherwise I might need to rebase and given the size of it, I really would prefer to avoid this :D

@koalatux
Copy link
Contributor Author

Ok, no problem. Just let me know if I need to rebase my PR when yours is merged.

@ivmarkov ivmarkov self-requested a review September 25, 2024 11:29
@ivmarkov
Copy link
Contributor

@kedars I'm merging this because the change surface is miniature and I'm quite sure this extension is correct.

@ivmarkov ivmarkov merged commit 850e02a into project-chip:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants