Skip to content

Commit

Permalink
Configure Time slicing for NVidia GPU e2e PR check
Browse files Browse the repository at this point in the history
  • Loading branch information
sutaakar committed Jul 8, 2024
1 parent 677417b commit c91a762
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/e2e_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ jobs:
- name: Checkout common repo code
uses: actions/checkout@v4
with:
repository: 'project-codeflare/codeflare-common'
ref: 'main'
repository: 'sutaakar/codeflare-common'
ref: 'gpu-time-slicing'
path: 'common'

- name: Set Go
Expand All @@ -61,6 +61,8 @@ jobs:

- name: Install NVidia GPU operator for KinD
uses: ./common/github-actions/nvidia-gpu-operator
with:
enable-time-slicing: true

- name: Deploy CodeFlare stack
id: deploy
Expand Down Expand Up @@ -115,7 +117,7 @@ jobs:

- name: Upload logs
uses: actions/upload-artifact@v4
if: always() && steps.deploy.outcome == 'success'
if: always() && steps.kind-install.outcome == 'success'
with:
name: logs
retention-days: 10
Expand Down
1 change: 1 addition & 0 deletions test/e2e/mnist_pytorch_appwrapper_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func TestMnistPyTorchAppWrapperGpu(t *testing.T) {
// Trains the MNIST dataset as a batch Job in an AppWrapper, and asserts successful completion of the training job.
func runMnistPyTorchAppWrapper(t *testing.T, accelerator string) {
test := With(t)
test.T().Parallel()

// Create a namespace and localqueue in that namespace
namespace := test.NewTestNamespace()
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/mnist_rayjob_raycluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ func TestMnistRayJobRayClusterGpu(t *testing.T) {

func runMnistRayJobRayCluster(t *testing.T, accelerator string, numberOfGpus int) {
test := With(t)
test.T().Parallel()

// Create a namespace and localqueue in that namespace
namespace := test.NewTestNamespace()
Expand Down Expand Up @@ -108,6 +109,7 @@ func TestMnistRayJobRayClusterAppWrapperGpu(t *testing.T) {
// Same as TestMNISTRayJobRayCluster, except the RayCluster is wrapped in an AppWrapper
func runMnistRayJobRayClusterAppWrapper(t *testing.T, accelerator string, numberOfGpus int) {
test := With(t)
test.T().Parallel()

// Create a namespace and localqueue in that namespace
namespace := test.NewTestNamespace()
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,5 @@ spec:
- name: "memory"
nominalQuota: "20G"
- name: "nvidia.com/gpu"
nominalQuota: "1"
nominalQuota: "4"
EOF

0 comments on commit c91a762

Please sign in to comment.