Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kube-rbac-proxy #191

Closed
ChristianZaccaria opened this issue Jul 21, 2023 · 0 comments · Fixed by #193
Closed

Remove kube-rbac-proxy #191

ChristianZaccaria opened this issue Jul 21, 2023 · 0 comments · Fixed by #193
Assignees
@ChristianZaccaria

Comments

@ChristianZaccaria
Copy link
Contributor

Description

kube-rbac-proxy was included as initial code as part of the Operator SDK framework. This proxy is adding more complexity towards exposing metrics.

To solve this issue, we made this PR #185 which is bypassing the kube-rbac-proxy and exposing the CodeFlare Operator metrics successfully. However since we won't be making use of kube-rbac-proxy, it is best to remove it.

This was carefully discussed with @anishasthana, as well taking into consideration that the odh-operator repo is removing the proxy as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianZaccaria ChristianZaccaria

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove kube-rbac-proxy and open metrics endpoint ChristianZaccaria/codeflare-operator
1 participant
@ChristianZaccaria