Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CodeFlare Operator metrics endpoint #185

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Jul 18, 2023

Resolves #169

Exposed the CodeFlare Operator metrics endpoint

Besides exposing the endpoint, there was a need to change the --metrics-bind-address=127.0.0.1:8080 args, from localhost to 0.0.0.0 for Prometheus to start scraping metrics successfully.

Tested with the CodeFlare Operator alert rules set on this PR: red-hat-data-services/odh-deployer#365

Note: this job was a collaborative effort between @Fiona-Waters, @dimakis, and myself @ChristianZaccaria

Prometheus

image

@ChristianZaccaria ChristianZaccaria requested review from dimakis and removed request for anishasthana and jbusche July 18, 2023 15:05
@sutaakar
Copy link
Contributor

AFAIK this change will effectively bypass rbac-proxy.
Is it intended? If so, is there any reason to have this proxy on operator?

@ChristianZaccaria
Copy link
Contributor Author

AFAIK this change will effectively bypass rbac-proxy. Is it intended? If so, is there any reason to have this proxy on operator?

This was not initially intended, however after careful consideration, we concluded that we will be removing the kube-rbac-proxy. #191

This PR lgtm if you're okay with it too. Thanks again for your help and for pointing this out.

@openshift-ci
Copy link

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a84b1d into project-codeflare:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of availability SLI for CodeFlare Operator
3 participants