Update README.md with release steps #118

sutaakar · 2023-06-01T07:38:24Z

Fixes #108

openshift-ci · 2023-06-01T07:38:28Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

KPostOffice

One small fix I think

KPostOffice · 2023-06-13T19:50:57Z

README.md

+- Build and release [MCAD](https://github.com/project-codeflare/multi-cluster-app-dispatcher)
+- Build and release [InstaScale](https://github.com/project-codeflare/instascale)
+- Build and release [CodeFlare-SDK](https://github.com/project-codeflare/codeflare-sdk)
+


I think there's a step missing here which is something along the lines of updating the values of MCAD and InstaScale where necessary.

Well, I haven't found any direct dependency on MCAD or InstaScale code apart from an image declaration in https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/defaults.go .

I mentioned these repositories as prerequisites because I consider operator as a "main" repo, handling other components, so to build it as last.

codeflare-operator/Makefile

Line 13 in 3180604

INSTASCALE_VERSION ?= v0.0.4

This value needs to be updated and the new defaults file must be generated if we are targeting a new release of InstaScale with the new CodeFlare operator release. The MCAD_VERSION variable will also need to be updated once @astefanutti 's PR with an MCAD version/custom image support is merged.

@KPostOffice readme adjusted to contain also version changes in files across repository.

KPostOffice · 2023-06-13T19:53:00Z

README.md

+
+3. Update CodeFlare Stack Compatibility Matrix in operator README.
+
+4. Create a release in CodeFlare operator repository, release notes should include new support matrix.


Possible future work is adding these steps to the existing GitHub action

https://github.com/marketplace/actions/create-release

Right, there is also a GitHub CLI for such action: gh release create ${{ github.event.inputs.tag }} --generate-notes

KPostOffice · 2023-06-13T19:54:48Z

README.md

+
+4. Create a release in CodeFlare operator repository, release notes should include new support matrix.
+
+5. Open a pull request to OpenShift community operators repository with latest bundle using make command, check that the created PR has proper content.


Also possible future work here. Create another GitHub action which opens PR to OpenShift community operator and updates tag.

astefanutti · 2023-06-16T13:29:41Z

README.md

+4. Update InstaScale and MCAD versions:
+- in [Makefile](https://github.com/project-codeflare/codeflare-operator/blob/main/Makefile#L12-L16).
+- in [mcad/deployment.yaml.tmpl](https://github.com/project-codeflare/codeflare-operator/blob/main/config/internal/mcad/deployment.yaml.tmpl#L28)
+- in [controllers/defaults.go](https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/defaults.go) by running `make defaults`


I don't think that's needed, as it's done when running make build as part of the release workflow.

I mention it here because the change needs to be merged, so it is good to merge it together with other version changes in one commit.

README.md

anishasthana · 2023-06-21T20:10:56Z

README.md

+
+8. Announce the new release in slack and mail lists, if any.
+
+9. Update the Distributed Workloads component in ODH.


As part of this, we will need to copy over / update the compatibilty matrix in the distributed workloads repo.

Added a note about updating compatibility matrix

anishasthana

Changes look good to me. @KPostOffice @astefanutti can you give it another look as well?

KPostOffice · 2023-06-22T13:59:18Z

README.md

+- in [Makefile](https://github.com/project-codeflare/codeflare-operator/blob/02e14b535b4f7172b0b809bcae4025008a1a968b/Makefile#L12-L16).
+- in [mcad/deployment.yaml.tmpl](https://github.com/project-codeflare/codeflare-operator/blob/main/config/internal/mcad/deployment.yaml.tmpl#L28)
+- in [controllers/defaults.go](https://github.com/project-codeflare/codeflare-operator/blob/main/controllers/defaults.go) by running `make defaults`


I think that this should be the first step shouldn't it?

It doesn't have to be, the Tag and Release GitHub action anyway replace this value when building the image.

openshift-ci · 2023-06-22T17:24:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress label Jun 1, 2023

sutaakar force-pushed the release-instructions branch from 25670e0 to f1de0b4 Compare June 6, 2023 06:21

sutaakar marked this pull request as ready for review June 6, 2023 06:22

openshift-ci bot removed the do-not-merge/work-in-progress label Jun 6, 2023

openshift-ci bot requested review from anishasthana and Maxusmusti June 6, 2023 06:22

sutaakar force-pushed the release-instructions branch 2 times, most recently from c309529 to 9783861 Compare June 12, 2023 07:40

KPostOffice reviewed Jun 13, 2023

View reviewed changes

sutaakar force-pushed the release-instructions branch from 9783861 to 4883a55 Compare June 14, 2023 06:59

sutaakar mentioned this pull request Jun 14, 2023

Create GitHub action to automate CodeFlare operator release #137

Closed

sutaakar force-pushed the release-instructions branch from 080b417 to df6c833 Compare June 14, 2023 09:00

sutaakar mentioned this pull request Jun 14, 2023

Create GitHub action to automate CodeFlare operator release #138

Merged

sutaakar force-pushed the release-instructions branch from df6c833 to fb92ac6 Compare June 15, 2023 06:52

sutaakar requested a review from KPostOffice June 15, 2023 10:11

sutaakar force-pushed the release-instructions branch from fb92ac6 to b3c9e25 Compare June 16, 2023 07:11

astefanutti reviewed Jun 16, 2023

View reviewed changes

sutaakar force-pushed the release-instructions branch 3 times, most recently from 7edb431 to 7f0c189 Compare June 21, 2023 11:58

anishasthana reviewed Jun 21, 2023

View reviewed changes

Update README.md with release steps

35bd873

sutaakar force-pushed the release-instructions branch from 7f0c189 to 35bd873 Compare June 22, 2023 07:36

sutaakar requested review from anishasthana and astefanutti June 22, 2023 07:37

anishasthana reviewed Jun 22, 2023

View reviewed changes

KPostOffice reviewed Jun 22, 2023

View reviewed changes

KPostOffice approved these changes Jun 22, 2023

View reviewed changes

openshift-ci bot assigned KPostOffice Jun 22, 2023

openshift-ci bot added the lgtm label Jun 22, 2023

openshift-ci bot added the approved label Jun 22, 2023

openshift-merge-robot merged commit 9a7746b into project-codeflare:main Jun 22, 2023

sutaakar deleted the release-instructions branch June 22, 2023 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.md with release steps #118

Update README.md with release steps #118

sutaakar commented Jun 1, 2023 •

edited

Loading

openshift-ci bot commented Jun 1, 2023

KPostOffice left a comment

KPostOffice Jun 13, 2023

sutaakar Jun 14, 2023

KPostOffice Jun 15, 2023

sutaakar Jun 16, 2023

KPostOffice Jun 13, 2023

sutaakar Jun 14, 2023 •

edited

Loading

KPostOffice Jun 13, 2023

sutaakar Jun 14, 2023

astefanutti Jun 16, 2023

sutaakar Jun 19, 2023

anishasthana Jun 21, 2023

sutaakar Jun 22, 2023

anishasthana left a comment

KPostOffice Jun 22, 2023

sutaakar Jun 22, 2023

openshift-ci bot commented Jun 22, 2023


		3. Update CodeFlare Stack Compatibility Matrix in operator README.

		4. Create a release in CodeFlare operator repository, release notes should include new support matrix.


		4. Create a release in CodeFlare operator repository, release notes should include new support matrix.

		5. Open a pull request to OpenShift community operators repository with latest bundle using make command, check that the created PR has proper content.


		8. Announce the new release in slack and mail lists, if any.

		9. Update the Distributed Workloads component in ODH.

Update README.md with release steps #118

Update README.md with release steps #118

Conversation

sutaakar commented Jun 1, 2023 • edited Loading

openshift-ci bot commented Jun 1, 2023

KPostOffice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sutaakar Jun 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anishasthana left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci bot commented Jun 22, 2023

sutaakar commented Jun 1, 2023 •

edited

Loading

sutaakar Jun 14, 2023 •

edited

Loading